-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File fields #1222
File fields #1222
Conversation
I'm in...no doubt 👍 |
So, I tried to identify which commits have happened in the mean time that affect any of the existing file field/type files. I used: git log d636282..master --pretty=oneline --follow fields/types/cloudinaryimage
git log d636282..master --pretty=oneline --follow fields/types/cloudinaryimages
git log d636282..master --pretty=oneline --follow fields/types/localfile
git log d636282..master --pretty=oneline --follow fields/types/localfiles
git log d636282..master --pretty=oneline --follow fields/types/s3file
git log d636282..master --pretty=oneline --follow fields/types/Field.js
git log d636282..master --pretty=oneline --follow fields/types/Type.js To get all commits that affected file field files, then unduped them and this is the result: f3369d7 Added space += className in CloudinaryImageField.js and added JSX quotes in EmailField.js So, to avoid regressions we need to make sure all of the above changes are merged/migrated to the file-field branch, before we can land this. @JedWatson @sebmck agreed? |
To view a diff of changes to those files: git difftool d636282..master -- fields/types/cloudinaryimage fields/types/cloudinaryimages fields/types/localfile fields/types/localfiles fields/types/s3file fields/types/Field.js fields/types/Type.js Maybe it's best to view differences file by file and make sure all applicable changes are transferred to |
I'm really sorry, but I'm almost certain there be dragons here, needs confirmation however, went through these just real quick:
Have to do with the backwards compatible fields, keeping them here for completeness:
I'll update with confirmed if I'm able to confirm this myself or get notification from someone else, and tick the boxes if solution have been pushed. |
…e added extremely easily
…files fields and alias them to their respective files/field field
+1 |
What's the status of this? |
yup. ditto. status? |
Status: trailing hopelessly behind. I hope to show this some love next week, since it's sorely needed. But, sooooo much has changed in the mean time and it wasn't easy to begin with ... sigh |
@creynders if you've got time to pick this up let me know, the only way out is through and this is a huge thing we need to get behind us. Hopefully we'll have some time next week at TM to apply effort specifically to getting this over the line so let's coordinate :) |
@JedWatson ready to put my teeth into it again. Will need to do some catching up though ... |
I would like to help you with this big task. Could you explain why https://github.com/keystonejs/storage was abandoned? |
@mahnunchik that was spearheaded by @grabbou and as many oss projects lost steam |
@morenoh149 What happened to @grabbou ? If it is not a secret. |
@mahnunchik help is more than welcome, thanks! There's a |
|
Yeah it definitely needs to be rebased first. |
Any luck with the merge? it is a very useful functionality, need it so much. @creynders @JedWatson |
Could I just use the branch |
Hi, I was unsuccessful with the rebase 😢 Someone who will make the rebase should have experience in js and in React too. |
oh, seems it is a big rebase |
+1 |
This is in its current state no longer mergeable, we'll be looking into redoing this with v0.4 based on the current ADMIN NOTE: Please do not delete the branch, we need it as a reference! |
@sebmck has contributed a functionally complete (?) implementation of generic
File
andFiles
fields.The job from here is to merge the latest changes in and ensure the fields work correctly across all the use-cases (including the implementation of the backwards compatible field types for
LocalFile
etc, which will remain until0.4.0
)Once these are up and running, we'll create branched
Image
versions of them which will resolve the issues floating around to makeFile
fields play more nicely with images (including previews, etc)Please sound out here if you're interest / capable of helping with the effort to get this merged!