Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Initial React View Engine #128

Closed
wants to merge 1 commit into from
Closed

Conversation

mgan59
Copy link
Contributor

@mgan59 mgan59 commented Sep 20, 2015

Overview

Added the React Template port of the current Default KeystoneTemplate. Currently the missing pieces would are the actual Email Message and the Gallery Views. Also, the base layout could use the inline editing javascript added back into place. Currently this includes the actual generator hooks to prompt user for the react template and to then generate components for the home, blog, message pages.

Architecture

Everything has been built as pure render components and placed into the components/elements folder. The components/views act as a proxy to the express handler transfer props to the actual base components/pages which then call the layouts/Layout base.

@mxstbr
Copy link
Contributor

mxstbr commented May 9, 2016

I definitely want to get this landed asap, since we've been really looking forward to making Keystone the best CMS to use with Single Page Applications. Thanks so much for taking the time to submit this! Could you rebase onto master so we can merge it?

Also, is there a reason this wasn't merged yet @JedWatson?

@mxstbr mxstbr added this to the 0.4 milestone May 9, 2016
@JedWatson
Copy link
Member

No, sorry for leaving this hanging so long @mgan59! Would be great to have.

@mgan59
Copy link
Contributor Author

mgan59 commented May 10, 2016

Hey no worries. I can get the rebase squared away this evening. This initial PR was sort of a preview for peeps, the gallery view isn't complete which shouldn't take to long to put together, happy to try and square that way if we are looking to merge. Will update with progress later. 😄

@mgan59
Copy link
Contributor Author

mgan59 commented May 17, 2016

Completed a rebase but have not confirmed that there are no errors, working through that spider web of requires in the app/_keystone.js was abit of a mess. Anyways, I need to setup a local dev environment for keystonejs/generator - it has been awhile and I'm on a new machine.

So will test/verify rebase was good and will take a look at what needs to happen for the gallery view.

@mgan59
Copy link
Contributor Author

mgan59 commented May 25, 2016

Have a working dev-setup for the generator now and had to resolve some minor issues with the ejs templating that occurred in _keystone. Generator is now working. Next steps are to verify initial the generated app is working when the server is fired up and a user navigates the front-end as expected. Also the followup Gallery piece still.

Side note: saw the notices for Jade deprecating and being renamed to Pug... something else that needs addressed =p

@JedWatson
Copy link
Member

This is a bit too behind to catch up now, we'll come back to react integration with the generator soon though. Thanks for the initial work @mgan59 and let us know if you're still interested in working on the generator with us!

@JedWatson JedWatson closed this Feb 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants