-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add functionality to operate on Workspace Membership #589
feat(cli): Add functionality to operate on Workspace Membership #589
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #589 +/- ##
===========================================
- Coverage 91.71% 87.19% -4.52%
===========================================
Files 111 110 -1
Lines 2510 2828 +318
Branches 469 426 -43
===========================================
+ Hits 2302 2466 +164
- Misses 208 362 +154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apps/cli/src/commands/workspace/membership/get-all-members.membership.ts
Outdated
Show resolved
Hide resolved
apps/cli/src/commands/workspace/membership/get-all-members.membership.ts
Outdated
Show resolved
Hide resolved
apps/cli/src/commands/workspace/membership/get-all-members.membership.ts
Outdated
Show resolved
Hide resolved
…hade-xyz#589) Co-authored-by: Rajdip Bhattacharya <[email protected]>
User description
Description
Improves CLI functionality to now work with workspace membership.
Fixes #548
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Enhancement
Description
Added new CLI functionality to manage workspace memberships:
Changes walkthrough 📝
membership.workspace.ts
Add workspace membership command structure
apps/cli/src/commands/workspace/membership.workspace.ts
memberships
membership operations
*.ts
Implement workspace membership command handlers
apps/cli/src/commands/workspace/membership/*.ts
functionality
commands
controller-instance.ts
Add workspace membership controller support
apps/cli/src/util/controller-instance.ts
*
Format email templates code
apps/api/src/mail/emails/*