Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: responsive landing #47

Merged
merged 7 commits into from
Dec 29, 2023
Merged

feat: responsive landing #47

merged 7 commits into from
Dec 29, 2023

Conversation

SRINJAYDASGUPTA-Git
Copy link
Contributor

@SRINJAYDASGUPTA-Git SRINJAYDASGUPTA-Git commented Dec 29, 2023

Type

Enhancement


Description

This PR introduces changes to make the landing page of the application mobile responsive. The main changes include:

  • Adjustments to the layout and sizing of elements on the landing page to ensure they fit and display properly on smaller screens.
  • Changes to the text size in the Links component to be responsive, displaying smaller on mobile and larger on desktop screens.

PR changes walkthrough

Relevant files                                                                                                                                 
Ui/ux changes
2 files
page.tsx                                                                                                       
    apps/web/app/page.tsx

    The changes in this file are primarily focused on making the
    landing page mobile responsive. This includes adjustments to
    div classes, flex properties, text sizes, and gaps between
    elements to ensure a better fit and layout on smaller
    screens.

+9/-10
Links.tsx                                                                                                     
    apps/web/components/Links.tsx

    The text size of the description in the Links component has
    been adjusted to be responsive, with a smaller size for
    mobile and the original size for larger screens.

+1/-1

User description

Description

fix(landing-page): Make mobile responsive

Fixes #41

Dependencies

Mention any dependencies/packages used

Future Improvements

Mention any improvements to be done in future related to any file/feature

Mentions

@rajdip-b

Screenshots of relevant screens

image

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

@codiumai-pr-agent-free codiumai-pr-agent-free bot added the type: enhancement New feature or request label Dec 29, 2023
Copy link
Contributor

PR Description updated to latest commit (3fd5a1d)

@rajdip-b rajdip-b changed the title Responsive landing feat: responsive landing Dec 29, 2023
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Making the landing page of the application mobile responsive
  • 📝 PR summary: This PR introduces changes to make the landing page of the application mobile responsive. The main changes include adjustments to the layout and sizing of elements on the landing page to ensure they fit and display properly on smaller screens, and changes to the text size in the Links component to be responsive.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 2, because the changes are mostly related to CSS and layout, which are straightforward to review.
  • 🔒 Security concerns: No

PR Feedback

💡 General suggestions: The PR seems to be well-structured and the changes are clear. However, it would be beneficial to add screenshots or a brief video showing the responsive behavior on different screen sizes. This would help reviewers understand the visual changes without needing to pull and run the code locally.

🤖 Code feedback:
relevant fileapps/web/app/page.tsx
suggestion      

Consider using more descriptive class names or adding comments to explain what each class does. This will make the code easier to understand and maintain. [medium]

relevant line

relevant fileapps/web/app/page.tsx
suggestion      

It's a good practice to avoid using magic numbers in the code. Consider defining constants for these values to make the code more readable and maintainable. [medium]

relevant line

relevant fileapps/web/components/Links.tsx
suggestion      

Consider using a CSS preprocessor like SASS or LESS. This will allow you to use variables for colors, sizes, etc., making the code cleaner and easier to maintain. [medium]

relevant line

{description}


✨ Usage tips:

To invoke the PR-Agent, add a comment using one of the following commands:

  • /review: Request a review of your Pull Request.
  • /describe: Update the PR title and description based on the contents of the PR.
  • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
  • /ask <QUESTION>: Ask a question about the PR.
  • /update_changelog: Update the changelog based on the PR's contents.
  • /add_docs 💎: Generate docstring for new components introduced in the PR.
  • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
  • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

Copy link
Member

@rajdip-b rajdip-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@rajdip-b rajdip-b merged commit 97bbb0c into keyshade-xyz:main Dec 29, 2023
5 checks passed
@SRINJAYDASGUPTA-Git SRINJAYDASGUPTA-Git deleted the responsive-landing branch December 29, 2023 19:14
@rajdip-b
Copy link
Member

rajdip-b commented Feb 2, 2024

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rajdip-b
Copy link
Member

rajdip-b commented Feb 9, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make landing page mobile responsive
2 participants