-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(platform): Added optional chaining due to strict null check #413
chore(platform): Added optional chaining due to strict null check #413
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
Yes, this was a known issue. Thanks for getting this solved! |
## [2.5.0](v2.4.0...v2.5.0) (2024-09-16) ### 🚀 Features * **api-client:** Added workspace controller ([#427](#427)) ([2f4edec](2f4edec)) * **api-client:** Added workspace role controller ([#430](#430)) ([b03ce8e](b03ce8e)) * **api-client:** Synced with latest API ([27f4309](27f4309)) * **api:** Add slug in entities ([#415](#415)) ([89e2fcc](89e2fcc)) * **api:** Included default workspace details in getSelf function ([#414](#414)) ([e67bbd6](e67bbd6)) * **platform:** Add loading skeleton in the [secure]s page ([#423](#423)) ([a97681e](a97681e)) * **schema:** Added a schema package ([01ea232](01ea232)) * **web:** Update about and careers page ([e167f53](e167f53)) ### 🐛 Bug Fixes * **api:** Error messages fixed in api-key service ([#418](#418)) ([edfbce0](edfbce0)) ### 📚 Documentation * Fixed minor typo in postman workspace link ([#411](#411)) ([ed23116](ed23116)) * Updated Postman links ([444bfb1](444bfb1)) ### 🔧 Miscellaneous Chores * **api:** Suppressed version check test in [secure] ([4688e8c](4688e8c)) * **api:** Update slug generation method ([#420](#420)) ([1f864df](1f864df)) ### 🔨 Code Refactoring * **API:** Refactor workspace-membership into a separate module ([#421](#421)) ([574170f](574170f)) * **platform:** added optional chaining due to strict null check ([#413](#413)) ([907e369](907e369))
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [2.5.0](keyshade-xyz/keyshade@v2.4.0...v2.5.0) (2024-09-16) ### 🚀 Features * **api-client:** Added workspace controller ([keyshade-xyz#427](keyshade-xyz#427)) ([2f4edec](keyshade-xyz@2f4edec)) * **api-client:** Added workspace role controller ([keyshade-xyz#430](keyshade-xyz#430)) ([b03ce8e](keyshade-xyz@b03ce8e)) * **api-client:** Synced with latest API ([27f4309](keyshade-xyz@27f4309)) * **api:** Add slug in entities ([keyshade-xyz#415](keyshade-xyz#415)) ([89e2fcc](keyshade-xyz@89e2fcc)) * **api:** Included default workspace details in getSelf function ([keyshade-xyz#414](keyshade-xyz#414)) ([e67bbd6](keyshade-xyz@e67bbd6)) * **platform:** Add loading skeleton in the [secure]s page ([keyshade-xyz#423](keyshade-xyz#423)) ([a97681e](keyshade-xyz@a97681e)) * **schema:** Added a schema package ([01ea232](keyshade-xyz@01ea232)) * **web:** Update about and careers page ([e167f53](keyshade-xyz@e167f53)) ### 🐛 Bug Fixes * **api:** Error messages fixed in api-key service ([keyshade-xyz#418](keyshade-xyz#418)) ([edfbce0](keyshade-xyz@edfbce0)) ### 📚 Documentation * Fixed minor typo in postman workspace link ([keyshade-xyz#411](keyshade-xyz#411)) ([ed23116](keyshade-xyz@ed23116)) * Updated Postman links ([444bfb1](keyshade-xyz@444bfb1)) ### 🔧 Miscellaneous Chores * **api:** Suppressed version check test in [secure] ([4688e8c](keyshade-xyz@4688e8c)) * **api:** Update slug generation method ([keyshade-xyz#420](keyshade-xyz#420)) ([1f864df](keyshade-xyz@1f864df)) ### 🔨 Code Refactoring * **API:** Refactor workspace-membership into a separate module ([keyshade-xyz#421](keyshade-xyz#421)) ([574170f](keyshade-xyz@574170f)) * **platform:** added optional chaining due to strict null check ([keyshade-xyz#413](keyshade-xyz#413)) ([907e369](keyshade-xyz@907e369))
User description
Description
Added optional chaining in platform code due to strict null check implementation
Fixes #412
PR Type
enhancement, bug_fix
Description
localStorage
to prevent errors in environments where it is not available.package.json
to include@keyshade/api-client
in dependencies.Changes walkthrough 📝
10 files
page.tsx
Add localStorage check and optional chaining
apps/platform/src/app/(main)/page.tsx
localStorage
before accessing it.page.tsx
Use optional chaining for secrets mapping
apps/platform/src/app/(main)/project/[project]/@secret/page.tsx
allSecrets
mapping.layout.tsx
Use optional chaining for project name access
apps/platform/src/app/(main)/project/[project]/layout.tsx
currentProject.name
.page.tsx
Use optional chaining for input focus
apps/platform/src/app/auth/invite/page.tsx
inputRef.current
focus calls.index.tsx
Use optional chaining for user name access
apps/platform/src/components/shared/navbar/index.tsx
data.name
.index.tsx
Use Boolean for conditional rendering
apps/platform/src/components/teams/teamTable/index.tsx
Boolean
for conditional rendering logic.line-tab.tsx
Use optional chaining for search comparison
apps/platform/src/components/ui/line-tab.tsx
search
comparison.env.ts
Use optional chaining for error handling
apps/platform/src/env.ts
workspace-storage.ts
Add localStorage checks for workspace storage
apps/platform/src/lib/workspace-storage.ts
localStorage
before accessing it.middleware.ts
Use optional chaining for cookie value access
apps/platform/src/middleware.ts
1 files
package.json
Update dependencies in package.json
package.json
@keyshade/api-client
to dependencies.