Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for managing configurations #91

Closed
6 tasks
rajdip-b opened this issue Jan 26, 2024 · 4 comments · Fixed by #149
Closed
6 tasks

Support for managing configurations #91

rajdip-b opened this issue Jan 26, 2024 · 4 comments · Fixed by #149
Assignees
Labels
help wanted Extra attention is needed scope: api Everything related to the API type: enhancement New feature or request
Milestone

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Jan 26, 2024

Description

Currently, keyshade only supports storing secrets. While this is nice, users might also want to store non-sensitive data such as application configurations. For example, SERVER_PORT.

Solution

This brings us to our second entity besides secret: Configuration. A configuration will necessarily be having similar features as that of secret, except these changes:

  • No Encrytion/decryption logic
  • No rotation feature

Scope of changes

For now, these changes are only local to the API. They include:

  • Create configuration POST /api/configuration/{projectId}
  • Update configuration PUT /api/configuration/{configurationId}
  • Delete configuration DELETE /api/configuration/{configurationId}
  • Get config by id GET /api/configuration/{configurationId}
  • Get all configs of project (paginated) GET /api/configuration/{projectId}
  • Get all configs (paginated) (admin only) GET /api/configuration/

Necessary tests for the same would be a huge plus!

@rajdip-b rajdip-b added type: enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed scope: api Everything related to the API labels Jan 26, 2024
@rajdip-b rajdip-b added this to the Release v1 milestone Jan 26, 2024
@rajdip-b rajdip-b moved this to Todo in keyshade-api Jan 26, 2024
@rajdip-b rajdip-b pinned this issue Jan 26, 2024
@lakshay-saini-au8
Copy link
Contributor

/attempt

Copy link

github-actions bot commented Feb 3, 2024

Assigned the issue to you!

@rajdip-b
Copy link
Member Author

rajdip-b commented Feb 5, 2024

@lakshay-saini-au8 hey! you can get started with this now.

@rajdip-b rajdip-b removed the good first issue Good for newcomers label Feb 8, 2024
@rajdip-b rajdip-b self-assigned this Feb 19, 2024
@rajdip-b rajdip-b moved this from Todo to In progress in keyshade-api Feb 19, 2024
@rajdip-b rajdip-b moved this from In progress to Under review in keyshade-api Feb 20, 2024
@github-project-automation github-project-automation bot moved this from Under review to Done in keyshade-api Feb 20, 2024
@rajdip-b rajdip-b unpinned this issue Feb 25, 2024
@rajdip-b
Copy link
Member Author

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed scope: api Everything related to the API type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants