Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to assign notes to secrets #116

Closed
rajdip-b opened this issue Feb 8, 2024 · 1 comment
Closed

Add feature to assign notes to secrets #116

rajdip-b opened this issue Feb 8, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed scope: api Everything related to the API type: enhancement New feature or request
Milestone

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Feb 8, 2024

Description

We would like all secrets to have an extra property called notes. This would allow the users to add a custom note to the secret (and configuration #91) so that they can relate to it better. This note would be editable by other users with permitted roles in the workspace as well.

Solution

  • The first change would be to add another field in the Secret model in the prisma.schema file
    note    String
  • Update the create.secret.ts.
  • Update the create and update functions of secret.service.ts.
  • Update the unit and integration tests accordingly

Alternatives

None

Additional context

The files to update can be found under:

  • apps/api/src/secret
  • apps/api/src/prisma
@rajdip-b rajdip-b added type: enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed scope: api Everything related to the API labels Feb 8, 2024
@rajdip-b rajdip-b added this to the Release v1 milestone Feb 8, 2024
@rajdip-b rajdip-b moved this to Todo in keyshade-api Feb 8, 2024
@rajdip-b
Copy link
Member Author

Completed by #151

@github-project-automation github-project-automation bot moved this from Todo to Done in keyshade-api Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed scope: api Everything related to the API type: enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant