Skip to content

Commit

Permalink
test(api): remove TODO from test
Browse files Browse the repository at this point in the history
  • Loading branch information
@rajdip-b
rajdip-b committed Feb 7, 2024
1 parent d59427e commit 0d68d57
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion apps/api/src/auth/controller/auth.controller.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ describe('AuthController', () => {
controllers: [AuthController],
providers: [
AuthService,
// Todo: Implement mockGithubOAuthStratergyFactory
GithubOAuthStrategyFactory,
ConfigService,
{ provide: MAIL_SERVICE, useClass: MockMailService },
Expand Down

3 comments on commit 0d68d57

@HarshPatel5940
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this todo? @rajdip-b

@rajdip-b
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this todo? @rajdip-b

Uh well, we won't need one. We want the auth providers to be active only in dev and prod env. Currently, if you don't specify the secrets, it wont be configured. So we won't be needing this mock implementation.

@HarshPatel5940
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh well, we won't need one. We want the auth providers to be active only in dev and prod env. Currently, if you don't specify the secrets, it wont be configured. So we won't be needing this mock implementation.

Oh k, got it!

Please sign in to comment.