CatchAll method + test on transport #3
Conversation
| return this.transport.send(err) | ||
| } | ||
|
|
||
| return null | ||
| } | ||
|
|
||
| catchAll (opts?: any): Boolean | void { |
There was a problem hiding this comment.
Pretty sure that's now enabled by default, we should automatically call it inside the init of the feature.
src/native.ts
Outdated
| @@ -0,0 +1,5 @@ | |||
| interface Error { | |||
| prepareStackTrace?: () => void, | |||
There was a problem hiding this comment.
i think the typings of node are available with @types/node
src/features/notify.ts
Outdated
| } | ||
|
|
||
| if (listener === 'unhandledRejection') { | ||
| error = 'You have triggered an unhandledRejection, you may have forgotten to catch a Promise rejection:\n' + error |
There was a problem hiding this comment.
i'm pretty sure we do not need to modify the error, maybe just add a console.error to indicate that the error come from an unhandledRejection should be enough ?
src/utils/error-callsites.ts
Outdated
| export default class ErrorCallSites { | ||
|
|
||
| static init () { | ||
| const orig = Error.prepareStackTrace |
There was a problem hiding this comment.
we should remove this, it has been tested but we saw a lot of performances issues in the past, specially with bluebird that create a lot of error just to keep track of the stack when using polyfill for promise.
| @@ -4,7 +4,7 @@ import * as stringify from 'json-stringify-safe' | |||
| debug('axm:transport') | |||
|
|
|||
| export default class Transport { | |||
| send (args: Error, print: Boolean): void { | |||
| send (args: Error | any, print?: Boolean): number { | |||
There was a problem hiding this comment.
I believe transport should in the manager folder since it need to be started before each feature.
src/features/notify.ts
Outdated
| return this.transport.send(err) | ||
| } | ||
|
|
||
| return null | ||
| } | ||
|
|
||
| catchAll (opts?: any): Boolean | void { | ||
| Callsites.init() |
There was a problem hiding this comment.
cf message in the callsite file
|
A little fix should be to check that the error that is received by |
src/features/probe.ts
Outdated
| import { Feature } from './featureTypes' | ||
| import Meter from '../probes/meter' | ||
|
|
||
| export default class ProbeFeature implements Feature { |
There was a problem hiding this comment.
Note that we don't want to name it Probe, that was the old name, it's way easier to our customer to understand metrics
src/features/probe.ts
Outdated
| @@ -0,0 +1,17 @@ | |||
| import { Feature } from './featureTypes' | |||
| import Meter from '../probes/meter' | |||
There was a problem hiding this comment.
We may want to use a 3rd party package to handle the actual compute, to discuss
No description provided.