feat(web): add Keyboard and KMXKeyboard classes 🎼
#12825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
Keyboard and KMXKeyboard classesKeyboard and KMXKeyboard classes 🎼
ermshiperete
force-pushed
the
refactor/web/jskeyboards
branch
from
27e7418 to
c359fe7
Compare
ermshiperete
force-pushed
the
feat/web/kmxkeyboard
branch
from
f8f844f to
ab81bde
Compare
ermshiperete
force-pushed
the
refactor/web/jskeyboards
branch
from
c359fe7 to
b4d78ce
Compare
ermshiperete
force-pushed
the
feat/web/kmxkeyboard
branch
from
ab81bde to
4759764
Compare
ermshiperete
force-pushed
the
feat/web/kmxkeyboard
branch
from
4759764 to
bb4d5d9
Compare
ermshiperete
force-pushed
the
refactor/web/jskeyboards
branch
from
b4d78ce to
f8ed96a
Compare
ermshiperete
force-pushed
the
feat/web/kmxkeyboard
branch
from
bb4d5d9 to
7767f3d
Compare
The `Keyboard` class can be either a JS or KMX keyboard. Also make use of the `Keyboard` class where it makes sense and add TODOs in the places that still need to be implemented for KMX keyboard support.
ermshiperete
force-pushed
the
feat/web/kmxkeyboard
branch
from
7767f3d to
08b261c
Compare
mcdurdin
approved these changes
Jan 15, 2025
Comment on lines
+56
to
+57
| // extract keyboard name from URI | ||
| const id = uri.split('#')[0].split('?')[0].split('/').pop().split('.')[0]; |
There was a problem hiding this comment.
Is the keyboard name guaranteed to be in the URI?
There was a problem hiding this comment.
Good point. I'll address this in a follow-up PR.
Comment on lines
8
to
14
| constructor(id: string, keyboard: km_core_keyboard) { | ||
| this.id = id; | ||
| this.keyboard = keyboard; | ||
| } | ||
|
|
||
| id: string; | ||
| keyboard: km_core_keyboard; |
There was a problem hiding this comment.
Suggested change
| constructor(id: string, keyboard: km_core_keyboard) { | |
| this.id = id; | |
| this.keyboard = keyboard; | |
| } | |
| id: string; | |
| keyboard: km_core_keyboard; | |
| constructor(public id: string, public keyboard: km_core_keyboard) { | |
| } |
Also, consider making these private properties with read-only getters.
Addresses code review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Keyboardclass can be either a JS or KMX keyboard. Also make use of theKeyboardclass where it makes sense and add TODOs in the places that still need to be implemented for KMX keyboard support.Part-of: #11293
@keymanapp-test-bot skip