Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(developer): use full github url in kmc copy parameters 🍒 #12773

Merged

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Dec 5, 2024

Cherry-picking to master as epic/shared-fonts may not land in 18.0, and we don't want the new kmc copy command to have unnecessarily changes to command line after release.

Fixes: #12746
Cherry-pick-of: #12754

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 5, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S16 milestone Dec 5, 2024
@darcywong00 darcywong00 changed the title change(developer): use full github url in kmc copy parameters change(developer): use full github url in kmc copy parameters 🍒 Dec 6, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@mcdurdin mcdurdin merged commit 7be5c62 into master Dec 6, 2024
7 checks passed
@mcdurdin mcdurdin deleted the chore/developer/12746-kmc-copy-full-gh-url-to-master branch December 6, 2024 07:01
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.154-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

change(developer): update kmc-copy to use full GitHub URLs rather than github: prefix
3 participants