Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web): Clean up .keyboard_info files in other web test folders 🎺 #9551

Closed
mcdurdin opened this issue Sep 12, 2023 · 0 comments · Fixed by #9619
Closed

chore(web): Clean up .keyboard_info files in other web test folders 🎺 #9551

mcdurdin opened this issue Sep 12, 2023 · 0 comments · Fixed by #9619
Assignees
@mcdurdin
Labels
chore epic-package-metadata web/
Milestone
A17S23

Comments

@mcdurdin
Copy link
Member

Should we also clean up .keyboard_info files in other web test folders?

web/src/test/manual/web/issue917-context-and-notany/test_917/test_917.keyboard_info
web/src/test/manual/web/issue2924/source/testvariable/testvariable.keyboard_info
web/src/test/manual/web/issue3701/test3701/test3701.keyboard_info

Originally posted by @darcywong00 in #9535 (comment)
@mcdurdin mcdurdin mentioned this issue Sep 12, 2023
Merged
@mcdurdin mcdurdin changed the title chore: Clean up .keyboard_info files in other web test folders chore(web): Clean up .keyboard_info files in other web test folders Sep 12, 2023
@mcdurdin mcdurdin self-assigned this Sep 12, 2023
@mcdurdin mcdurdin changed the title chore(web): Clean up .keyboard_info files in other web test folders chore(web): Clean up .keyboard_info files in other web test folders 🎺 Sep 12, 2023
@mcdurdin mcdurdin added this to the A17S22 milestone Sep 12, 2023
@mcdurdin mcdurdin mentioned this issue Sep 25, 2023
Merged
mcdurdin added a commit that referenced this issue Sep 25, 2023
@mcdurdin
chore(developer): remove .keyboard_info sources
a093507 
Fixes #9551.

Removes various .keyboard_info files from test fixtures and also removes
generation of .keyboard_info source files from kmconvert, alongside now-
redundant tests (cvt.dpr).
@mcdurdin mcdurdin linked a pull request Sep 25, 2023 that will close this issue
chore(developer): remove .keyboard_info sources 🎺 #9619
Merged
@mcdurdin mcdurdin modified the milestones: A17S22, A17S23 Sep 30, 2023
@mcdurdin mcdurdin closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
chore epic-package-metadata web/
Projects
None yet
Milestone
A17S23
Development

Successfully merging a pull request may close this issue.

chore(developer): remove .keyboard_info sources 🎺 keymanapp/keyman
1 participant
@mcdurdin