codestyle: Type annotate various modules and add them to mypy #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanberger
force-pushed
the
stefanberger/annotate_various_ad_mypy
branch
from
4c6ace3 to
f9c7fef
Compare
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stefanberger
force-pushed
the
stefanberger/annotate_various_ad_mypy
branch
from
f9c7fef to
22ce83f
Compare
Signed-off-by: Stefan Berger <[email protected]>
Signed-off-by: Stefan Berger <[email protected]>
Signed-off-by: Stefan Berger <[email protected]>
stefanberger
force-pushed
the
stefanberger/annotate_various_ad_mypy
branch
from
22ce83f to
9222f81
Compare
Signed-off-by: Stefan Berger <[email protected]>
Signed-off-by: Stefan Berger <[email protected]>
Type-annotate ca_util.py and also minimally annotate revocation_notifier.py so ca_util.py passed mypy checks. Signed-off-by: Stefan Berger <[email protected]>
stefanberger
force-pushed
the
stefanberger/annotate_various_ad_mypy
branch
from
9222f81 to
f65039f
Compare
aplanas
reviewed
Dec 6, 2022
| @@ -498,7 +511,7 @@ def read_private(warn=False): | |||
| return {"revoked_keys": [], "ca": b""}, base64.b64encode(crypto.generate_random_key()).decode() | |||
|
|
|||
|
|
|||
| def main(argv=sys.argv): # pylint: disable=dangerous-default-value | |||
| def main(argv: List[str] = sys.argv) -> None: # pylint: disable=dangerous-default-value | |||
There was a problem hiding this comment.
Ah this disable should be a TODO. This is very dangerous indeed.
Signed-off-by: Stefan Berger <[email protected]>
Signed-off-by: Stefan Berger <[email protected]>
Signed-off-by: Stefan Berger <[email protected]>
Signed-off-by: Stefan Berger <[email protected]>
Signed-off-by: Stefan Berger <[email protected]>
…mypy Signed-off-by: Stefan Berger <[email protected]>
Signed-off-by: Stefan Berger <[email protected]>
stefanberger
force-pushed
the
stefanberger/annotate_various_ad_mypy
branch
from
4dbaa9b to
0ac97b3
Compare
aplanas
approved these changes
Dec 6, 2022
THS-on
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR type-annotates various modules and adds them to mypy.