This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ID
KEYCLOAK-12054
Additional Information
This Pull Request fixes cache issue on Quay (it was reusing image build cache for shell files, see containers/buildah#1906). The proposed solution uses Docker Multi-Stage builds feature, where we have a builder image (that builds our Go program) and a final image (that contains a binary).
This approach has a lot of advantages:
operator-hub build
command.--cache-from
(so that you can reuse previous build results and modify only the final image).However, there are some downsides as well:
1.13
", which is installed by default in Fedora. From now on, please use Podman (or newer Docker version).Dockerfile
to the root and create a symbolic link to it frombuild
directory.Dockerfile
(Quay do not discover symbolic links correctly).But overall, I think it's worth it.
Verification Steps
podman build .
executed from project rootoperator-sdk-local build --image-builder podman whatever --verbose
Checklist:
Additional Notes