-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding metadata name for event filter statistics #283
Conversation
Which filters does this apply to? And what does targeted mean? The ones for which the filter can apply? |
This is for filters which filter events e. g. : GenEventFilter. The targeted number of events is number of events specified in the steering or |
What about cases where there are multiple filters? Should there be the possibility to add a filter name? |
Than this needs to be a vector of some struct/class (consisting of three numbers and a name for the filter)? |
I think having the name is fine but we can keep discussing how it's used. Also, why is the number of events requested important? How is that information going to be used? Is it useless when you request more events than available (it only tells you that there weren't enough events) |
@kjvbrt any answers to my last comment? Do we want the comment to be quite restrictive? Does one always need the number of events? Maybe we should just remove the comment entirely like the other constants? |
My goal was to standardize also vector members, but that is probably too restrictive. |
The
vector<int>
contains three values: Seen, accepted and targeted.BEGINRELEASENOTES
ENDRELEASENOTES