Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #77 #78

Merged
merged 1 commit into from
Jul 8, 2023
Merged

fix for issue #77 #78

merged 1 commit into from
Jul 8, 2023

Conversation

jp1995
Copy link
Contributor

@jp1995 jp1995 commented Jul 7, 2023

yay appears to be the only one of these supported aur helpers that stores the built package and keeps it even after the package has been removed, and then on (re)install outputs -> cava-0.8.3-1 already made -- skipping build where the -- skipping in the output makes the changed_iter bool remain False in the current live version, hence the issue.

So a very minor edit here to the changed_iter condition -- skipping --> up-to-date -- skipping.

I tested this with yay, paru, trizen, pikaur, aurman and makepkg.

To test, I manually installed a package, and then ran the same play as in the issue to test install (with the package already installed), uninstall and reinstall. In every case the output was the desired:

TASK [test : Test install] ***************************************************************
ok: [iota]

TASK [test : Remove test package] ********************************************************
--- before
+++ after
@@ -1 +0,0 @@
-cava-0.8.3-1

changed: [iota]

TASK [test : Test reinstall] *************************************************************
changed: [iota]

I would have to set up an x86 vm to test pacaur as a dependency failed to build for aarch64. Pacaur hasn't been updated in 5 years though and is unmaintained so I'm not even sure it works anymore.

There might be some extra testing you want to do as I obviously don't know this module particularly well and might have missed something.

@kewlfft kewlfft merged commit 8d177a7 into kewlfft:master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants