Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yay appears to be the only one of these supported aur helpers that stores the built package and keeps it even after the package has been removed, and then on (re)install outputs
-> cava-0.8.3-1 already made -- skipping build
where the-- skipping
in the output makes the changed_iter bool remain False in the current live version, hence the issue.So a very minor edit here to the
changed_iter
condition-- skipping
-->up-to-date -- skipping
.I tested this with yay, paru, trizen, pikaur, aurman and makepkg.
To test, I manually installed a package, and then ran the same play as in the issue to test install (with the package already installed), uninstall and reinstall. In every case the output was the desired:
I would have to set up an x86 vm to test pacaur as a dependency failed to build for aarch64. Pacaur hasn't been updated in 5 years though and is unmaintained so I'm not even sure it works anymore.
There might be some extra testing you want to do as I obviously don't know this module particularly well and might have missed something.