Add pkgbuild option to build local package

[ckotte]

Sometimes AUR packages are broken and not fixed. With the pkgbuild option, a local directory with the PKGBUILD and build files can be specified to build the package.

[kewlfft]

I think it is a nice feature, thanks for your contribution. I have some comments:

• The option name pkgbuild is used by pikaur, but wouldn't local be more self explanatory?

• I am fine with your makepkg implementation of it

• I don't want to be too specific about pikaur and have a specific function for it. Other helpers may have some ways to achieve the same now or in the future (see Request: Equivalent of Yaourt's PKGBUILD Option: -Pi Jguer/yay#694 and [Feature Request] Local "AUR repository" / Local packages from PKGBUILD Jguer/yay#647) and I would prefer to keep the tool as generic and scalable as possible.

[ckotte]

I could rename it to local_pkgbuild.

I use pikaur in my playbook and I have a specific use case for local pkgbuilds. I just added the functionality for makepkg after I implemented it for pikaur.

Other helpers cannot build local pkgbuilds yet. You could change the function in the future and keep the same options for pikaur and add the commands for the other helpers.

Or you wait until every helper implements it and then you can add it to your module. However, this probably won't happen. pacaur is also discontinued and the issue for yay is open since 2 years.

[ckotte]

Are you happy if I change the new pikaur function to a generic function where someone could add the functionality for other helpers in the future??

[kewlfft]

yes adding or for removing a helper should require minimum maintenance, it often happens. We have to think if pikaur is discontinued, it should be a question of adding or removing an element in a list.

[ckotte]

I changed the code. Now there's a list for a local package build and a generic function that assumes the last argument is the PKGBUILD file. Both are only used if local_pkgbuild is specified.

This will work in theory with another helper that just need to be added to the new list. In theory because it will only work if the helper requires the PKGBUILD file as the last argument. It doesn't work anymore if the helper requires the directory or if it needs to execute the command inside the directory, etc. pp.

The code is now more bloated. Tell me what you think. I will rebase the PR later.

[kewlfft]

it seems good thanks for the changes

[ckotte]

ok. rebase done.

[kewlfft]

can't extra_args be used to add the remove dependencies options to makepkg ?

[kewlfft]

for behavior that varies depending on the helper let's not try to change or harmonize in the background, this would add complexity. --skip-pgp-check was implemented before extra_args which was only added last June. If extra_args does the job, we could maybe remove the skip pgp check (breaking change).

[ckotte]

I removed the last commit. Sorry. I don't have time for this.

[ckotte]

I would not remove this option because there's also a description that explicitly says why it's useful in the first place. This helps users if they have exactly this issue/use case of installing only one package (AUR helper) that needs GnuPG configured.

[soloturn]

i'd love if the option "yay -U" learns to take either a package file and installs it, or PKGBUILD and builds it beforehand, instead of having "local_pkgbuild" as addition. yay -U only would use the PKGBUILD in the current dir. thanks a lot for this contribution!

[kewlfft]

@soloturn what you describe and would like yay to support is it what pikaur does already with the pkgbuild option?

[ckotte]

I implemented all suggestions. Please check.