Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect the right design set for vcard3 #680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kewisch
Copy link
Owner

@kewisch kewisch commented May 2, 2024

Fixes #363

I don't see a better way to adjust the design set than to modify the getter. ICAL.parse() detects the design set but only returns jCal, so it needs to be somewhere in the component code.

@kewisch kewisch requested a review from leftmostcat May 2, 2024 09:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8921649271

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 97.981%

Totals Coverage Status
Change from base Build 8909071766: 0.004%
Covered Lines: 9359
Relevant Lines: 9535

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

designSet is populated with vcard instead of vcard3
2 participants