Fix stack trace on custom ParserError #665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caught a ParserError with a weird stack, and it turns out the custom mangling we did before doesn't really cut it. With ES6+ we can simplify the instance variables.
I've only tested this in recent node and the firefox error console, both seem to contain a stack. The node stack even skips over the error class even without Error.captureStackTrace.
Does this look ok?