Fix recurrence iteration where there is a negative BYMONTHDAY rule. #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3004908279
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3012284281
💛 - Coveralls |
leftmostcat
reviewed
Sep 8, 2022
| @@ -675,6 +676,28 @@ suite('recur_iterator', function() { | |||
| '2015-03-31T08:00:00' | |||
| ] | |||
| }); | |||
| testRRULE('FREQ=MONTHLY;INTERVAL=3;BYMONTHDAY=-1', { | |||
There was a problem hiding this comment.
At a glance, it's not clear to me what this test is looking for. A comment would be good, or even a failure reason if testRRULE() provides for that.
| @@ -302,9 +302,13 @@ ICAL.RecurIterator = (function() { | |||
| } | |||
|
|
|||
| } else if (this.has_by_data("BYMONTHDAY")) { | |||
| if (this.last.day < 0) { | |||
| // Attempting to access `this.last.day` will cause the date to be normalised and | |||
There was a problem hiding this comment.
Appreciate the comments here, let me understand this review. 😅
darktrojan
force-pushed
the
negative-bymonthday
branch
from
66511d2 to
2b34544
Compare
|
I've added some comments to the individual tests. It's probably still as clear as mud. I also moved the inner |
leftmostcat
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally bug 1789362. Calculation of the initial recurrence date is wrong where
BYMONTHDAYis negative.For example, if the rule is
FREQ=MONTHLY;INTERVAL=3;BYMONTHDAY=-1the event recurs at 2, 5, 8 etc. months instead of 3, 6, 9 etc.. I've figured out that this is because we're storing a negative day value in anICAL.Time. When we attempt to read the value it gets normalised to the previous month because the day value is negative.