feat: add support for all aws regions and their az #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneeshrelan
commented
Sep 17, 2020
| @@ -5,12 +5,13 @@ import * as _ from "lodash"; | |||
| */ | |||
| export function normalizeServiceName( | |||
| name: string, | |||
| opts?: { snakeCase?: boolean; stripPrefix?: boolean } | |||
| opts?: { snakeCase?: boolean; stripPrefix?: boolean; useBlacklist?: boolean } | |||
There was a problem hiding this comment.
The existing blacklist for F_S was conflicting with the region AF_SOUTH_1 so seemed like a good addition to have an optional setting here for future use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for all AWS regions and their Availability Zones. All regions are not easily available from an official API, but following the existing approach of a
fetchand anupdate, have utilized this repository that has updated list of AWS regions with their availability zones including non-public regions like the govcloud and China regionsThis is my first pull request so would love to get feedback and suggestions here, so do let me know if I might have missed out on something or need to add details here