Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined behavior in read #32

Closed
cafce25 opened this issue Sep 10, 2023 · 2 comments
Closed

Undefined behavior in read #32

cafce25 opened this issue Sep 10, 2023 · 2 comments

Comments

@cafce25
Copy link

cafce25 commented Sep 10, 2023

The implementation of read invokes UB by using SoapySDRDevice_readStream to write to buffers which is behind a shared reference. It can probably be solved by changing the signature from &[&mut [E]] to &mut [&mut [E]] unfortunately that's a breaking change.
kevinmehall added a commit that referenced this issue Sep 13, 2023
@kevinmehall
Fix RxStream::read API to not write through a shared reference (#32)
4d61a64
@kevinmehall
Copy link
Owner

Good catch, thanks for noticing. Fixed in 4d61a64.

Let me check if there are other breaking changes that are desirable, and I'll publish 0.4 soon.

@kevinmehall
Copy link
Owner

Released in 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinmehall @cafce25