Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging of dev branch into master #8

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

merging of dev branch into master #8

wants to merge 18 commits into from

Conversation

kevindublin
Copy link
Owner

I had a few issues that prevented me from getting the project launched on Ubuntu 18.04. I think some were self-inflicted (why did I run "npm audit fix" after updating a few dependencies individually in the "Update Dependencies" challenge task?), but I figured I'd communicate them to explain why it took me so long to get this completed and, more importantly, demonstrate issues others might encounter who take the challenge. The first has already been corrected:

./docker-compose.yml

  • Line 14 & Line 26 were missing forward slashes at the beginning of the respective file paths.

./application/Dockerfile

  • Line 3 the file path kept failing to find the directory with "node" present in the pathway, despite being defined that way in the docker-compose.yml.
  • Line 5, since the commands are virtually the same and a URL wasn't being used, I switched the ADD command to COPY and copied over the entire directory instead of just the "package.json," so the "src" folder would copy as well. In retrospect I shouldn't want the node_modules etc. to copy over since that's built on start, will refactor, but worried it might break at the moment.
  • Line 7 I originally added "RUN ls -al" to check where files were actually being copied, deleted now

./server/Dockerfile

  • Line 5 see line 3 above.
  • Line 7 see line 5 above.
  • Line 9 see line 7 above

./application/package.json

  • Line 14 "audit fix" auto updates "react-scripts" to version 3.4.1 which creates a nasty bug which forces a silent exit code 0. I downgraded to 3.4.0 here, but it looks like one of the other options is to add stdin_open: true to docker-compose.yml.

./application/src/private.js

  • Line 3 Nothing is running at localhost or the IP specified by React development server. While I could load the web app, it wouldn't connect to the server from the default IP. I had to force it to the default, even though I'm not on Windows. Temporary workaround to complete the other challenges.

kevindublin and others added 18 commits June 14, 2020 08:12
fix(orderForm-component): fixed typo in menuItemChosen method
fix(view-order-component): display zero in minutes and seconds
feat(nav-component): import loginUser from authActions after attempt …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant