Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-update with 403 code #141

Closed
juev opened this issue Oct 1, 2023 · 1 comment · Fixed by #142
Closed

self-update with 403 code #141

juev opened this issue Oct 1, 2023 · 1 comment · Fixed by #142

Comments

@juev
Copy link
Collaborator

juev commented Oct 1, 2023

~/go/sr/gi/ke/gobrew on  master
 16:17:38  ❯ while true; gobrew self-update; end;
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
[INFO] your version is already newest
==> [Error] Cannot read response: 403 Forbidden
Downloading 100% |████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| (5.9/5.9 MB, 17 MB/s)
Upgrade successful
==> [Error] Cannot read response: 403 Forbidden
Downloading 100% |████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| (5.9/5.9 MB, 13 MB/s)
Upgrade successful
==> [Error] Cannot read response: 403 Forbidden
Downloading 100% |████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| (5.9/5.9 MB, 16 MB/s)
Upgrade successful
==> [Error] Cannot read response: 403 Forbidden
Downloading 100% |████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| (5.9/5.9 MB, 16 MB/s)
Upgrade successful
^C⏎

We use a call to GitHub api to get the latest version of gobrew, at a certain point in time when accessing api we get errors with 403 code, instead of the supposed 429. After that, this code does not take into account, and we are trying to update the version, which is not correct.

You need to add 403 code processing. And check the error checking steps.

juev added a commit that referenced this issue Oct 1, 2023
@juev
Copy link
Collaborator Author

juev commented Oct 1, 2023

@kevincobain2000
I really don't want to create a separate branch in order to keep track of the latest version.

And it is not yet clear how to get the latest version without using GitHub api.
It remains only to correctly handle errors on the part of our requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant