Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json fixes #86

Merged
merged 2 commits into from
Mar 15, 2016
Merged

package.json fixes #86

merged 2 commits into from
Mar 15, 2016

Conversation

ivuorinen
Copy link
Contributor

Sorry about the extra commits, I thought I was already sending you the pull request.

Currently it's impossible to npm install kevinchappell/formBuilder because Path must be a string. Received [ 'dist/*' ].

This patch fixes that, and other validity problems package.json had.

Validated with http://package-json-validator.com

Fixes following errors and warnings:

{
  "valid": false,
  "errors": [
    "Type for field main, was expected to be string, not object",
    "Url not valid for repository: kevinchappell/formBuilder"
  ],
  "warnings": [
    "Missing recommended field: bugs",
    "Missing recommended field: author",
    "Missing recommended field: contributors"
  ],
  "recommendations": [
    "Missing optional field: dependencies",
    "Missing optional field: engines"
  ]
}
@kevinchappell
Copy link
Owner

Excellent! I never did direct install always git clone then npm install without problem so had no idea. Great fix.

kevinchappell added a commit that referenced this pull request Mar 15, 2016
@kevinchappell kevinchappell merged commit 8749b74 into kevinchappell:master Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants