[FIX] Format Name Attr correctly #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -317,9 +317,7 @@ const FormBuilder = function(opts, element) { | |||
| field = Object.assign({}, $field) | |||
| } | |||
|
|
|||
| if (!field.name) { | |||
There was a problem hiding this comment.
Without this check, what happens when saved data is loaded? will it replace the name?
There was a problem hiding this comment.
Actually, I found utils.nameAttr() output to be the same as field.name in most cases, maybe I'll look into more. Because I thought the FormBuilder generated that value automatically.
There was a problem hiding this comment.
It does generate it if one isn't set. My concern was that if an existing form was loaded, the saved value could be overwritten. If a user sets a custom name, that custom value would be overwritten.
There was a problem hiding this comment.
Cool, i've check the field name inside name utility function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This might resolve #736