Radio group "Other" option input should hide after switching to other option #808
Comments
kevinchappell
added a commit
that referenced
this issue
Oct 5, 2018
Merged
kevinchappell
added a commit
that referenced
this issue
Oct 31, 2018
* Code format changes * wip * Update Demo, expose api normal jQuery plugin way * remove indexRender.html, unify demos * remove demoRender.css * Fix duplicate custom controls, toggle render * remove regen dep * update demo * remove gulp * upgrade module, webpack and minor style changes * autocomplete.js code style * update docs * Update docs * Add travis.yml Remove unused modules Update icon-font editing and saving * Remove test data, improve stickyControls, ensure DOM is ready * reduce file churn * Remove columns doc * update mi18n, add support checkbox custom attributes, bump version * Fix label overflow problem, resolves #779 * Add allowStageSort option, resolves #777 * Add documentation * Enable multiple select field for typeUserAttrs, resolves #776 * fix bug where empty className is not applied * Features: onFieldAdd option and toggleFieldEdit action, resolves #772 * Add setData and render actions to formRender, resolves #770 * fix attribute placeholder typo, fix label added when it should be removed, resolves #763 * label saving issue for html labels WIP * Fix label saving, add esc to close data modal, resolves #757 * update font editing docs * feature, add toggletAllFieldEdit * Add onOpenFieldEdit option, closeAllFieldEdit action, scrollToFieldOnAdd option * fix inputset bug * start fieldEditContainer option * remove console.log, use spaces instead of tabs for data formatting * Add layout and layout templates docs * fix(label): ensure html from label is correctly escaped, resolves #816 * Code style changes * Fix code style * Add: replaceFields, cleanup * Update docs, do not disable className or name attributes- resolves #819 * Update typeUserAttrs docs, resolves #810 * Other option should hide input value when deselected, resolves #808 * Ensure custom attributes are included in exported data resolves #824 resolves #773 * Add: disableHTMLLabels option, resolves #747 * remove replace comma, resolves #740 * Fix attrString util, Add: disableSubtypes, resolves #739 * Fix: current formData not carried over to new formBuilder instance on language change, resolves #735 * Fix: name attribute for inputs with multiple, resolves #736 * add onremove to typeUserEvents * Fix: new option name, resolves #687 * Fix: doubleclick event handler, resolves #535 * Lock dev dependency versions * Fixed issue 530. Modified helpers.js::xmlSave() to serialize field data so any XML in a field's attributes is properly escaped. (#804) * Fix bug with clear() as reported in #750 (#828) Add control type check to clear() so that method doesn't reset the value for checkboxes and radio buttons, which caused the userData getter to work incorrectly. * use yarn instead of npm * Update xmlSave * Demo build updates WIP * Use existing formBuilder instance instead of creating a new one on setLang * add formbuilder-languages module, remove network dependency, cleanup * fix typo * Fix inline checkbox/radio * Add deploy script * Just ensure build passes for now so we can get this release out this week * v2.10.0
kevinchappell
added a commit
that referenced
this issue
Oct 31, 2018
* Code format changes * wip * Update Demo, expose api normal jQuery plugin way * remove indexRender.html, unify demos * remove demoRender.css * Fix duplicate custom controls, toggle render * remove regen dep * update demo * remove gulp * upgrade module, webpack and minor style changes * autocomplete.js code style * update docs * Update docs * Add travis.yml Remove unused modules Update icon-font editing and saving * Remove test data, improve stickyControls, ensure DOM is ready * reduce file churn * Remove columns doc * update mi18n, add support checkbox custom attributes, bump version * Fix label overflow problem, resolves #779 * Add allowStageSort option, resolves #777 * Add documentation * Enable multiple select field for typeUserAttrs, resolves #776 * fix bug where empty className is not applied * Features: onFieldAdd option and toggleFieldEdit action, resolves #772 * Add setData and render actions to formRender, resolves #770 * fix attribute placeholder typo, fix label added when it should be removed, resolves #763 * label saving issue for html labels WIP * Fix label saving, add esc to close data modal, resolves #757 * update font editing docs * feature, add toggletAllFieldEdit * Add onOpenFieldEdit option, closeAllFieldEdit action, scrollToFieldOnAdd option * fix inputset bug * start fieldEditContainer option * remove console.log, use spaces instead of tabs for data formatting * Add layout and layout templates docs * fix(label): ensure html from label is correctly escaped, resolves #816 * Code style changes * Fix code style * Add: replaceFields, cleanup * Update docs, do not disable className or name attributes- resolves #819 * Update typeUserAttrs docs, resolves #810 * Other option should hide input value when deselected, resolves #808 * Ensure custom attributes are included in exported data resolves #824 resolves #773 * Add: disableHTMLLabels option, resolves #747 * remove replace comma, resolves #740 * Fix attrString util, Add: disableSubtypes, resolves #739 * Fix: current formData not carried over to new formBuilder instance on language change, resolves #735 * Fix: name attribute for inputs with multiple, resolves #736 * add onremove to typeUserEvents * Fix: new option name, resolves #687 * Fix: doubleclick event handler, resolves #535 * Lock dev dependency versions * Fixed issue 530. Modified helpers.js::xmlSave() to serialize field data so any XML in a field's attributes is properly escaped. (#804) * Fix bug with clear() as reported in #750 (#828) Add control type check to clear() so that method doesn't reset the value for checkboxes and radio buttons, which caused the userData getter to work incorrectly. * use yarn instead of npm * Update xmlSave * Demo build updates WIP * Use existing formBuilder instance instead of creating a new one on setLang * add formbuilder-languages module, remove network dependency, cleanup * fix typo * Fix inline checkbox/radio * Add deploy script * Just ensure build passes for now so we can get this release out this week * v2.10.0
pfranza
pushed a commit
to pfranza/formBuilder
that referenced
this issue
Nov 21, 2018
* Code format changes * wip * Update Demo, expose api normal jQuery plugin way * remove indexRender.html, unify demos * remove demoRender.css * Fix duplicate custom controls, toggle render * remove regen dep * update demo * remove gulp * upgrade module, webpack and minor style changes * autocomplete.js code style * update docs * Update docs * Add travis.yml Remove unused modules Update icon-font editing and saving * Remove test data, improve stickyControls, ensure DOM is ready * reduce file churn * Remove columns doc * update mi18n, add support checkbox custom attributes, bump version * Fix label overflow problem, resolves kevinchappell#779 * Add allowStageSort option, resolves kevinchappell#777 * Add documentation * Enable multiple select field for typeUserAttrs, resolves kevinchappell#776 * fix bug where empty className is not applied * Features: onFieldAdd option and toggleFieldEdit action, resolves kevinchappell#772 * Add setData and render actions to formRender, resolves kevinchappell#770 * fix attribute placeholder typo, fix label added when it should be removed, resolves kevinchappell#763 * label saving issue for html labels WIP * Fix label saving, add esc to close data modal, resolves kevinchappell#757 * update font editing docs * feature, add toggletAllFieldEdit * Add onOpenFieldEdit option, closeAllFieldEdit action, scrollToFieldOnAdd option * fix inputset bug * start fieldEditContainer option * remove console.log, use spaces instead of tabs for data formatting * Add layout and layout templates docs * fix(label): ensure html from label is correctly escaped, resolves kevinchappell#816 * Code style changes * Fix code style * Add: replaceFields, cleanup * Update docs, do not disable className or name attributes- resolves kevinchappell#819 * Update typeUserAttrs docs, resolves kevinchappell#810 * Other option should hide input value when deselected, resolves kevinchappell#808 * Ensure custom attributes are included in exported data resolves kevinchappell#824 resolves kevinchappell#773 * Add: disableHTMLLabels option, resolves kevinchappell#747 * remove replace comma, resolves kevinchappell#740 * Fix attrString util, Add: disableSubtypes, resolves kevinchappell#739 * Fix: current formData not carried over to new formBuilder instance on language change, resolves kevinchappell#735 * Fix: name attribute for inputs with multiple, resolves kevinchappell#736 * add onremove to typeUserEvents * Fix: new option name, resolves kevinchappell#687 * Fix: doubleclick event handler, resolves kevinchappell#535 * Lock dev dependency versions * Fixed issue 530. Modified helpers.js::xmlSave() to serialize field data so any XML in a field's attributes is properly escaped. (kevinchappell#804) * Fix bug with clear() as reported in kevinchappell#750 (kevinchappell#828) Add control type check to clear() so that method doesn't reset the value for checkboxes and radio buttons, which caused the userData getter to work incorrectly. * use yarn instead of npm * Update xmlSave * Demo build updates WIP * Use existing formBuilder instance instead of creating a new one on setLang * add formbuilder-languages module, remove network dependency, cleanup * fix typo * Fix inline checkbox/radio * Add deploy script * Just ensure build passes for now so we can get this release out this week * v2.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description: Radio group "Other" option input should hide after switching to other option.
Environment Details:
Expected Behavior
I would expect that text input for "Other" option would hide when switching to other options.
Actual Behavior
Text input at "Other" option remains visible.
Steps to Reproduce
Setup radio group field with enabled "Other" option. When selecting "Other" option in form, text input shows up. Now switch to other options (other than "Other"), text input is still visible.
The text was updated successfully, but these errors were encountered: