Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GP model specification in s5_fit.py #747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix GP model specification in s5_fit.py #747

wants to merge 2 commits into from

Conversation

jbrande
Copy link
Collaborator

@jbrande jbrande commented Feb 11, 2025

Handling issue #746 and further GP testing, if needed.

@jbrande jbrande requested a review from taylorbell57 February 20, 2025 03:47
@jbrande
Copy link
Collaborator Author

jbrande commented Feb 20, 2025

I couldn't get george to work at first, but I think I've diagnosed that now. There was another issue in the GPModel eval(), where george GPs would end up with evaluated models of different lengths than the time axis, caused by a minor typo neglecting to pass the mask through to the kernel input in the predict() step. George is still painfully slow, though, so this might not actually help anyone, lol.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.69%. Comparing base (93c15c6) to head (2b9c8be).
Report is 130 commits behind head on main.

Files with missing lines Patch % Lines
src/eureka/S5_lightcurve_fitting/models/GPModel.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
+ Coverage   57.03%   57.69%   +0.66%     
==========================================
  Files         113      113              
  Lines       14362    14475     +113     
==========================================
+ Hits         8192     8352     +160     
+ Misses       6170     6123      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant