Add the before_handle_response
option
#594
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #544.
The problem
Currently callbacks defined using the
before_record_response
can modify responses, but this creates an inconsistency where e.g. unit test cases see unmodified responses when cassettes are being recorded, and modified ones when they are later played back.The solution
The
before_handle_response
can be used to define callbacks instead. The response modifications now apply equally to live responses when recording cassettes as well as played back responses later:This is an alternative to the
alter_live_response = True
option implemented in #595.