Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aiohttp support #266

Merged
merged 14 commits into from
Aug 14, 2016
Merged

Aiohttp support #266

merged 14 commits into from
Aug 14, 2016

Conversation

lamenezes
Copy link
Collaborator

Solves #209

@kevin1024
Copy link
Owner

😯wow!

@kevin1024
Copy link
Owner

Thanks for the contribution. See if you can goof with the travis/pytest config so it only runs the aiohttp tests on python3.4+

@lamenezes lamenezes force-pushed the aiohttp-support branch 3 times, most recently from bd04dd3 to 9a52148 Compare August 11, 2016 05:27
@lamenezes lamenezes force-pushed the aiohttp-support branch 2 times, most recently from 721d489 to c65ff0e Compare August 12, 2016 15:26
@lamenezes
Copy link
Collaborator Author

The newest version of flake8 (>3) [1] does not support python 2.6, 3.2 and 3.3 and it is causing this build to fail when running tests for py26-flakes

[1] https://flake8.pycqa.org/en/latest/release-notes/3.0.0.html

@kevin1024
Copy link
Owner

Heh ok. See if you can disable flakes on py26 I'm that case

@lamenezes
Copy link
Collaborator Author

It finally passed 😄

@kevin1024 kevin1024 merged commit f9d7ccd into kevin1024:master Aug 14, 2016
@drgarcia1986
Copy link

👏 👏 👏
Thanks a lot @lamenezes

@lamenezes lamenezes deleted the aiohttp-support branch September 22, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lamenezes @kevin1024 @drgarcia1986