fix: avoid redirect loops when axios calls an unauthorized API #6450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have not been able to test it out. [EDIT] tested and approved |
MilosPaunovic
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
I've tested it by inviting new user with email only (no groups or access added), then accepted invite in different (private) window and it logged me in properly as user with no permission (which is expected) and showed me Blueprints, Plugins and Setttings pages in the left menu, which is also expected.
When I changed the URL manually to ui/dashboard it redirected me to 403 page, so also expected.
elevatebart
added a commit
that referenced
this pull request
Dec 13, 2024
* fix: avoid redirect loops when axios calls an unauthorized API * use the proper structure for axios * protect against empty request data
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when axios calls an API that it is not supposed to have access to, it's immediately supposing that the JWT is expired.
It requests a refresh of the token and retries the request, which in its turn returns 401 unauthorized.
And request a new token refresh.
This loop goes on until browser crashes.