feat: store metrics in a dedicated repository #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
metrics
branch
2 times, most recently
from
e7c30aa to
ef81861
Compare
loicmathieu
force-pushed
the
metrics
branch
7 times, most recently
from
a32a18c to
d1acf9c
Compare
tchiotludo
force-pushed
the
develop
branch
2 times, most recently
from
0f6a784 to
320c925
Compare
loicmathieu
force-pushed
the
metrics
branch
2 times, most recently
from
0cfd900 to
bacb7f4
Compare
tchiotludo
requested changes
Mar 13, 2023
core/src/main/java/io/kestra/core/repositories/MetricRepositoryInterface.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/kestra/core/models/executions/TaskRunAttempt.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/kestra/core/models/executions/AbstractMetricEntry.java
Outdated
Show resolved
Hide resolved
| @@ -23,7 +24,7 @@ | |||
| @JsonSubTypes.Type(value = Timer.class, name = "timer"), | |||
| }) | |||
| @ToString | |||
| @EqualsAndHashCode | |||
| @EqualsAndHashCode(exclude="creationTime") | |||
There was a problem hiding this comment.
Seems to be too magical, maybe have a proper method compare instead of really on equals?
There was a problem hiding this comment.
Isn't it the purpose of Lombok to provide magical highly productive trick ?
core/src/main/java/io/kestra/core/queues/QueueFactoryInterface.java
Outdated
Show resolved
Hide resolved
loicmathieu
force-pushed
the
metrics
branch
2 times, most recently
from
da34774 to
0822cc8
Compare
|
Warning, if #1076 is merged before the name of the migration must be updated! |
Will be usefull for the next steps on metric usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.