Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide all deprecated plugins in the Plugins UI #4526

Closed
anna-geller opened this issue Aug 2, 2024 · 6 comments · Fixed by #7039
Closed

Hide all deprecated plugins in the Plugins UI #4526

anna-geller opened this issue Aug 2, 2024 · 6 comments · Fixed by #7039
Assignees
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working kind/customer-request Requested by one or more customers

Comments

@anna-geller
Copy link
Member

Describe the issue

See https://share.descript.com/view/bpmC3CeMXRP :)

image

Environment

  • Kestra Version:
  • Operating System (OS/Docker/Kubernetes):
  • Java Version (if you don't run kestra in Docker):
@anna-geller anna-geller added the bug Something isn't working label Aug 2, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Aug 2, 2024
@anna-geller anna-geller added the kind/quick-win Seems to be quick to do label Aug 2, 2024
@loicmathieu
Copy link
Member

It's because we open the first in the list, not sure we can do anything about it at this stage.

Or we may change to open a plugin group page with a list of plugins instead of going to the first one.

@anna-geller
Copy link
Member Author

We should find a way to hide all deprecated plugins from the Plugins page in the UI and website. On the website, we asked Taron kestra-io/docs#1626

@loicmathieu
Copy link
Member

On the UI it's a bit more problematic as if a user uses a deprecated task, he still needs to be able to access its documentation.

@anna-geller
Copy link
Member Author

Documentation is still available.

Here is my thinking, you can say whether you agree:

  1. If a user already uses a deprecated plugin in their flow, they can access the documentation within the Editor or from the docs on the website (see the image below)
  2. If a user explores plugins via the Plugins UI, they should only see active plugins (deprecated plugins shouldn't be shown)

agree?

image

@anna-geller anna-geller changed the title Shell task in the plugin UI links to the deprecated Bash task instead of to Shell task Hide all deprecated plugins in the Plugins UI Aug 7, 2024
@anna-geller anna-geller added the area/frontend Needs frontend code changes label Aug 7, 2024
@brian-mulier-p
Copy link
Member

brian-mulier-p commented Sep 6, 2024

To handle it we would have to duplicate the API call to retrieve plugins without deprecated tasks for this home page, not sure we want to do that considering the issue which is really minor imo 🤔

@anna-geller
Copy link
Member Author

anna-geller commented Sep 16, 2024

Discussed today: let's add a filter to remove deprecated plugins and not show them both on the website kestra.io/plugins and on the UI /ui/plugins/ (in the UI: direct access like https://preview-oss.kestra.io/ui/plugins/io.kestra.plugin.core.debug.Echo will still work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working kind/customer-request Requested by one or more customers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants