fix(webserver): ensure queues are not closed in nioEventLoop

kestra-io · Jan 27, 2025 · b518a7b · b518a7b
1 parent 9273d73
commit b518a7b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/core/src/main/java/io/kestra/core/services/ExecutionLogService.java b/core/src/main/java/io/kestra/core/services/ExecutionLogService.java
@@ -11,6 +11,7 @@
 import org.slf4j.event.Level;
 import reactor.core.publisher.Flux;
 import reactor.core.publisher.FluxSink;
+import reactor.core.scheduler.Schedulers;
 
 import java.io.ByteArrayInputStream;
 import java.io.InputStream;
@@ -40,6 +41,7 @@ public Flux<Event<LogEntry>> streamExecutionLogs(final String tenantId,
         final AtomicReference<Runnable> disposable = new AtomicReference<>();
 
         return Flux.<Event<LogEntry>>create(emitter -> {
+
                 // send a first "empty" event so the SSE is correctly initialized in the frontend in case there are no logs
                 emitter.next(Event.of(LogEntry.builder().build()).id("start"));
 
@@ -65,9 +67,11 @@ public Flux<Event<LogEntry>> streamExecutionLogs(final String tenantId,
                 }));
             }, FluxSink.OverflowStrategy.BUFFER)
             .doFinally(ignored -> {
-                if (disposable.get() != null) {
-                    disposable.get().run();
-                }
+                Schedulers.boundedElastic().schedule(() -> {
+                    if (disposable.get() != null) {
+                        disposable.get().run();
+                    }
+                });
             });
     }
 

diff --git a/webserver/src/main/java/io/kestra/webserver/controllers/api/ExecutionController.java b/webserver/src/main/java/io/kestra/webserver/controllers/api/ExecutionController.java
@@ -1518,9 +1518,11 @@ public Flux<Event<Execution>> follow(
                 cancel.set(receive);
             }, FluxSink.OverflowStrategy.BUFFER)
             .doFinally(ignored -> {
-                if (cancel.get() != null) {
-                    cancel.get().run();
-                }
+                Schedulers.boundedElastic().schedule(() -> {
+                    if (cancel.get() != null) {
+                        cancel.get().run();
+                    }
+                });
             });
     }