[PoC] Discover customizations #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davismcphee
force-pushed
the
discover-extensions
branch
from
1d9403d to
245dac4
Compare
davismcphee
force-pushed
the
discover-extensions
branch
2 times, most recently
from
0714d06 to
e84970a
Compare
## Summary Closes elastic#156153 A small refactoring of the formatters tests to stabilize and unskip them Build 200 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2227#_
## Summary Fix elastic#156423 We were only using the schema for validation if its version was an *exact* match with the current stack version, meaning that any previous schema was ignored (and even introducing a minor was causing the schema to be ignored). This PR addresses it, by always using the closest previous schema available. --------- Co-authored-by: Kibana Machine <[email protected]>
## Summary Closes elastic#156821 Updating chromedriver dependency to match the latest Chrome release
…elastic#155499) Addresses elastic#155510 ## Summary This PR shows min and max values of time series counter field in the field popover. Before: <img width="400" alt="Screenshot 2023-04-21 at 13 26 37" src="https://user-images.githubusercontent.com/1415710/233624673-fc07a6b0-7e14-4936-aa7b-0d177f395fef.png"> After: <img width="500" alt="Screenshot 2023-04-21 at 13 22 50" src="https://user-images.githubusercontent.com/1415710/233624506-d6b0a3f7-23bb-4178-a01a-ae78e664cd9d.png"> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
## Summary Fixes Enterprise Search guided onboarding links which broke due to UI changes recently. https://user-images.githubusercontent.com/1410658/236779703-010884f0-7708-43e0-8f77-e3e0be456452.mov
## Summary I think this does this trick: https://user-images.githubusercontent.com/7784120/236454659-4922084f-7637-462f-b654-d46d9550b68b.mov
## Summary Resolves elastic#136856 - Add async keyword where it should have been. - Split archive into kbn and es archives... instigated by Pierre's comment: elastic#136856 (comment) - Note: Had to use both archive types as one archive is "hidden", and cannot be accessed via the kbn client. - Unload via Pierre's "new" clean method. - Add shell fn to print out server's currently loaded so's, with user and pass hardcoded for local dev.
Hides preview charts in the following APM rules until elastic#156625 (WIP) gets merged. - APM Latency threshold - APM Failed transaction rate - APM Error count threshold
…ws without a time field (elastic#156836) Closes elastic#156663 ## Summary In "Save search" modal "Store time with saved search" toggle will appear only for time-based data views.
…rough bulk actions (elastic#156866) (elastic#156905) ## Summary Original ticket: elastic#156866 These changes fix the issue with the conditional actions in bulk editing. We did not add action filter attributes to the bulk editing scheme. More details here elastic#156866 (comment)
…ilters (elastic#156702) ## Summary This PR fixes the following issue elastic#156590 where a users configuration for their alert page filters can prevent them from seeing the alert in the table. In this PR we clear the filters to only show the required status filter, with no selection, to rely primarily on the kql query filter for the alert id. Demo: https://user-images.githubusercontent.com/17211684/236332095-ac5583ec-6b5f-4ee2-9c23-9391b54263ba.mov It also fixes a bug where the flyout when opened wasn't unmounted when navigating away from a page and back to it as seen here: The bug: https://user-images.githubusercontent.com/17211684/236333550-b41925f9-a06c-4aa9-931b-beecf4c9ae9b.mov With the fix: https://user-images.githubusercontent.com/17211684/236334123-a0e3169e-2ec8-4754-92d2-65f2f369fa4f.mov ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [elastic-apm-node](https://togithub.com/elastic/apm-agent-nodejs) | [`^3.44.1` -> `^3.45.0`](https://renovatebot.com/diffs/npm/elastic-apm-node/3.44.1/3.45.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>elastic/apm-agent-nodejs</summary> ### [`v3.45.0`](https://togithub.com/elastic/apm-agent-nodejs/releases/tag/v3.45.0) [Compare Source](https://togithub.com/elastic/apm-agent-nodejs/compare/v3.44.1...v3.45.0) For more information, please see the [changelog](https://www.elastic.co/guide/en/apm/agent/nodejs/current/release-notes-3.x.html#release-notes-3.45.0). ##### Elastic APM Node.js agent layer ARNs |Region|ARN| |------|---| |af-south-1|arn:aws:lambda:af-south-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |ap-east-1|arn:aws:lambda:ap-east-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |ap-northeast-1|arn:aws:lambda:ap-northeast-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |ap-northeast-2|arn:aws:lambda:ap-northeast-2:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |ap-northeast-3|arn:aws:lambda:ap-northeast-3:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |ap-south-1|arn:aws:lambda:ap-south-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |ap-southeast-1|arn:aws:lambda:ap-southeast-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |ap-southeast-2|arn:aws:lambda:ap-southeast-2:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |ap-southeast-3|arn:aws:lambda:ap-southeast-3:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |ca-central-1|arn:aws:lambda:ca-central-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |eu-central-1|arn:aws:lambda:eu-central-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |eu-north-1|arn:aws:lambda:eu-north-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |eu-south-1|arn:aws:lambda:eu-south-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |eu-west-1|arn:aws:lambda:eu-west-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |eu-west-2|arn:aws:lambda:eu-west-2:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |eu-west-3|arn:aws:lambda:eu-west-3:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |me-south-1|arn:aws:lambda:me-south-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |sa-east-1|arn:aws:lambda:sa-east-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |us-east-1|arn:aws:lambda:us-east-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |us-east-2|arn:aws:lambda:us-east-2:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |us-west-1|arn:aws:lambda:us-west-1:267093732750:layer:elastic-apm-node-ver-3-45-0:1| |us-west-2|arn:aws:lambda:us-west-2:267093732750:layer:elastic-apm-node-ver-3-45-0:1| </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/elastic/kibana). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS40IiwidXBkYXRlZEluVmVyIjoiMzUuNzEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…tic#155815) ## Summary This work was originally done by @jughosta in elastic#150712, I just added a couple of integration tests and opened another PR for it. Fixes elastic#140426. #### Original PR summary: This PR adds support for `namespaces` param in create data view API as per docs https://www.elastic.co/guide/en/kibana/current/data-views-api-create.html#data-views-api-properties <img width="300" alt="Screenshot 2023-02-09 at 15 04 55" src="https://user-images.githubusercontent.com/1415710/217835577-fa4286ff-89f4-4de2-97b0-62c04f756858.png"> Previous functionality is still in place: * setting "default" space if "namespaces" param is not provided <img width="300" alt="Screenshot 2023-02-09 at 15 06 55" src="https://user-images.githubusercontent.com/1415710/217835951-d274c8ba-5bd9-4c36-9487-c2dbd5ce42de.png"> * setting the specified in URL space ID if "namespaces" param is not provided <img width="300" alt="Screenshot 2023-02-09 at 15 06 34" src="https://user-images.githubusercontent.com/1415710/217836019-81f36a16-157f-4ce9-9d19-c5685d633acc.png"> ### Checklist - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] ~Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))~ - [ ] ~Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~ - [ ] ~This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Julia Rechkunova <[email protected]>
…e action output data rows (elastic#156734) ## Summary - Fixes the color used to highlight a row from the output of the `processes` response action so that selected content (via mouse) is still legible when the kibana dark theme is used. Fixes: elastic#154594
…se and remove redundant endpoint data (elastic#156709) ## Summary - Removes several pieces of data from the Host Details search strategy response that is now available via the `hostInfo` property of the data returned. This PR is a follow up from elastic#154961 (comment)
## Summary Fixes the docLink for "build-connector". This was going to a 404 due to a small typo.
…mn on Group by resources findings table (elastic#156938) ## Summary This PR is for fixing the issue we have with sorting on posture score column on Group by resources findings table where clicking on the column doesn't do anything ## Before https://user-images.githubusercontent.com/8703149/236698942-04799955-1d2d-4bb8-931c-0ef1589b92f3.mov ## After https://user-images.githubusercontent.com/8703149/236698949-381d4264-54f9-4639-b541-2fb6fec2dbfa.mov
…tic#156864) Closes elastic#150686 ## Summary Add integration test to cover integration installation in multiple spaces Steps followed: - Install System integration - Create new space - Uninstall System integration - Install again in the new space - Verify that integration is added successfully, assets are created and tagged with Managed and System tags --------- Co-authored-by: Kibana Machine <[email protected]>
…lastic#156366) ## Summary This PR removes the `fields` parameter from the bulk get cases internal API. It also returns a subset of the cases attributes. Fixes: elastic#156364 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…dashboard (elastic#156893) ## Summary This PR handles : elastic#149096 - Fixes the redirection of `View all open alerts` button - Adds cypress tests for Detection and Response dashboard |Before|After| |---|---| |<video src="https://user-images.githubusercontent.com/108654988/213136589-b7ba4a54-68cb-4723-9b6f-8560b1d7ee55.mp4">|<video src="https://user-images.githubusercontent.com/7485038/236519746-2d5e5e5a-84a6-4762-9ddf-6f0039c5410a.mov">| ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
…t status via alert flyout. (elastic#156988) ## Summary This PR handles elastic#156646 |Before|After| |---|---| |<video src="https://user-images.githubusercontent.com/18648970/235540206-8f6713a7-3619-449d-bd22-9ac8280b8439.mov" /> | <video src="https://user-images.githubusercontent.com/7485038/236759487-2e80a908-55dd-4c26-8549-44a317eac4d7.mov" /> | <video src="https://user-images.githubusercontent.com/7485038/236828096-9f7a1892-8038-4893-9dd6-379544579243.mov" /> |
davismcphee
force-pushed
the
discover-extensions
branch
from
e84970a to
61cc06e
Compare
kertal
pushed a commit
that referenced
this pull request
Jun 23, 2023
](https://renovatebot.com){kind=link}
…e & improves code coverage (#15) ## [Security Solution] Security Assistant: Reduces the public API surface & improves code coverage - Reduces the public API surface - improves code coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proof of concept for the Discover customizations framework.