Improve parallel processing #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 2, 2021 17:28
By default the maximum number of connections per route is set to [DEFAULT_MAX_CONN_PER_ROUTE](https://javadoc.io/static/org.elasticsearch.client/elasticsearch-rest-client/7.4.2/org/elasticsearch/client/RestClientBuilder.html#DEFAULT_MAX_CONN_PER_ROUTE) which is 10. I additionally set the maximum number of connections for all routes in total to the same value (default is [DEFAULT_MAX_CONN_TOTAL](https://javadoc.io/static/org.elasticsearch.client/elasticsearch-rest-client/7.4.2/org/elasticsearch/client/RestClientBuilder.html#DEFAULT_MAX_CONN_TOTAL) = 30). I don't think it makes sense to expose this parameter as well in the config file as glutton uses only a single route.
|
Thanks a lot @mkardas and sorry to have been so slow to examine and merge your PR. This looks all good, I am merging into the working branch kermitt2:version-0.3 as I am working on the next version. |
|
Ok oops I did some tests and it should have been merged with master before the release, this is indeed required to avoid long hanging. Let's redo release 0.2. Thank you again for the fixes. |
kermitt2
added a commit
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of fixes to improve processing.