Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PII as additional "strong" identifier #29

Closed
kermitt2 opened this issue May 17, 2019 · 10 comments
Closed

PII as additional "strong" identifier #29

kermitt2 opened this issue May 17, 2019 · 10 comments
Assignees

Comments

@kermitt2
Copy link
Owner

Just realize now, the lookup can also be made with the PII (PII/DOI mapping being provided by the public ISTEX metadata). Useful in particular for getting the OA version of Elsevier publications.

@kermitt2
Copy link
Owner Author

ok it's a bit more upstream than I thought because the PII are not indexed from the ISTEX mapping
@JsonIgnoreProperties({"pii"})
so it's easy to add, it will require reloading the ISTEX mapping and add the additional parameter.

Note: the goal is to have them exploited by the web extension on sciencedirect.com search result page.

@lfoppiano
Copy link
Collaborator

@kermitt2 you mean to add pii as lookup in the /oa entry point or also in the /lookup entry pont?

@kermitt2
Copy link
Owner Author

yes adding it in general, so as a DOI or a PMID.

@lfoppiano lfoppiano self-assigned this May 18, 2019
lfoppiano added a commit that referenced this issue May 18, 2019
@lfoppiano
Copy link
Collaborator

Should be implemented

Examples:

http://localhost:8080/service/oa/pii/1460-2105
http://localhost:8080/service/lookup?pii=1460-2105

Please note that in the output, we take just the first PII (same as for getPmc, getPmid, getArk - see LookupEngine.java: method injectIdsByIstexData). Not sure how many cases with multiple ids are actually existing...

@kermitt2
Copy link
Owner Author

kermitt2 commented May 19, 2019

The PII in your examples looks like the ISSN.

PII is unique. Here is an example

http://localhost:8080/service/lookup?pii=S0266462305050762

Provided by the ISTEX mapping:

{"corpusName":"cambridge","istexId":"CC91E0F1789978CE79D653533100BA315CA337B3","ark":["ark:/67375/6GQ-9RTTRBZ7-G"],"doi":["10.1017/S0266462305050762"],"pmid":["16262981"],"pii":["S0266462305050762"]}

(although it is not an OA resource in this case, lookup should work and be equivalent to:

http://localhost:8080/service/lookup?doi=10.1017%2FS0266462305050762

I tried to find quickly in the code where the ISSN is used as PII but I didn't find.

@kermitt2
Copy link
Owner Author

kermitt2 commented May 19, 2019

From the PR version, it seems that the PMID lookup are not working too (but DOI and istexid are).

http://localhost:8080/service/lookup?pmid=16262981

gives 404

@lfoppiano
Copy link
Collaborator

oups... sorry! I was wondering that ids like 1460-2105 looked familiar...

I'm going to double-check.

Thanks for the feedback.

@lfoppiano
Copy link
Collaborator

I've checked the pii and there are few cases where the pii is somehow the issn: you can see them at http://localhost:8080/service/data/istex/pii (for the loading I've just uncommented the @JsonIgnoreProperties({"pii"}))

I've tested the example http://localhost:8080/service/lookup?pmid=16262981 and does't work on both version, are you sure this ID exists? I've debugged and this item is not in my database, have you realoaded with more recent data?

I've tried with other cases and they are working:

Other examples:

should work fine.

You example: http://localhost:8080/service/lookup?pii=S0266462305050762 should now work properly.

@kermitt2
Copy link
Owner Author

Thanks ! So the PII example indeed works now:
http://localhost:8080/service/lookup?pii=S0266462305050762

As well the other above PII examples and all the others I tried.

pmid=16262981 is the PMID returned by http://localhost:8080/service/lookup?pii=S0266462305050762 so it exists.

But you're right, it is also not working with the previous version, http://cloud.science-miner.com/glutton/service/lookup?pmid=16262981 also gives 404. So it's not related to PII. I open another issue for this one.

kermitt2 added a commit that referenced this issue May 22, 2019
@kermitt2
Copy link
Owner Author

so thanks it looks all good !
Of course, it's hard to find open access versions for the PII we have in the current mapping :/
We would need to extend the coverage of PII/DOI mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants