-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PII as additional "strong" identifier #29
Comments
ok it's a bit more upstream than I thought because the PII are not indexed from the ISTEX mapping Note: the goal is to have them exploited by the web extension on sciencedirect.com search result page. |
@kermitt2 you mean to add pii as lookup in the |
yes adding it in general, so as a DOI or a PMID. |
Should be implemented Examples: http://localhost:8080/service/oa/pii/1460-2105 Please note that in the output, we take just the first PII (same as for getPmc, getPmid, getArk - see LookupEngine.java: method injectIdsByIstexData). Not sure how many cases with multiple ids are actually existing... |
The PII in your examples looks like the ISSN. PII is unique. Here is an example Provided by the ISTEX mapping: {"corpusName":"cambridge","istexId":"CC91E0F1789978CE79D653533100BA315CA337B3","ark":["ark:/67375/6GQ-9RTTRBZ7-G"],"doi":["10.1017/S0266462305050762"],"pmid":["16262981"],"pii":["S0266462305050762"]} (although it is not an OA resource in this case, lookup should work and be equivalent to:
I tried to find quickly in the code where the ISSN is used as PII but I didn't find. |
From the PR version, it seems that the PMID lookup are not working too (but DOI and istexid are). gives 404 |
oups... sorry! I was wondering that ids like 1460-2105 looked familiar... I'm going to double-check. Thanks for the feedback. |
I've checked the pii and there are few cases where the pii is somehow the issn: you can see them at http://localhost:8080/service/data/istex/pii (for the loading I've just uncommented the @JsonIgnoreProperties({"pii"})) I've tested the example http://localhost:8080/service/lookup?pmid=16262981 and does't work on both version, are you sure this ID exists? I've debugged and this item is not in my database, have you realoaded with more recent data? I've tried with other cases and they are working: Other examples:
should work fine. You example: http://localhost:8080/service/lookup?pii=S0266462305050762 should now work properly. |
Thanks ! So the PII example indeed works now: As well the other above PII examples and all the others I tried.
But you're right, it is also not working with the previous version, http://cloud.science-miner.com/glutton/service/lookup?pmid=16262981 also gives 404. So it's not related to PII. I open another issue for this one. |
so thanks it looks all good ! |
Just realize now, the lookup can also be made with the PII (PII/DOI mapping being provided by the public ISTEX metadata). Useful in particular for getting the OA version of Elsevier publications.
The text was updated successfully, but these errors were encountered: