-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for 'subset' and interpolation' arguments (ImageDataGenerator) #9817
Conversation
keras/preprocessing/image.py
Outdated
@@ -680,6 +680,8 @@ def flow(self, x, y=None, batch_size=32, shuffle=True, seed=None, | |||
save_prefix: str (default: `''`). Prefix to use for filenames of saved pictures | |||
(only relevant if `save_to_dir` is set). | |||
save_format: one of "png", "jpeg" (only relevant if `save_to_dir` is set). Default: "png". | |||
subset: Subset of data (`"training"` or `"validation"`) if | |||
validation_split is set in ImageDataGenerator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put "`" around code keywords.
…) and for 'interpolation' argument (flow_from_directory)
Hi @fchollet , I have updated the style of the doc lines I added.
A simple example of this issue is that the lines I added were simply copy and pasted from the ones found in the I would prefer not to change the whole doc style in this commit in order to keep its goal meaningful and compact. Please let me know if you agree. |
In general all code keywords should be between backquotes. The only exception would potentially be string values, where it matters less, but even in this case backquotes are still better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ack-embeddings-from-layer-outputs * upstream/master: (68 commits) fit/evaluate_generator supporting native tensors (keras-team#9816) keras-team#9642 Add kwarg and documentation for dilation_rate to SeparableConvs (keras-team#9844) Document that "same" is inconsistent across backends with strides!=1 (keras-team#9629) Improve tests by designating dtype of sample data (keras-team#9834) Add documentation for 'subset' and interpolation' arguments (ImageDataGenerator) (keras-team#9817) Revert default theme to readthedocs Various docs fixes. Fix conflict Add support for class methods documentation (keras-team#9751) Add missing verbose opt for evaluate_generator (keras-team#9811) Added `data_format` to flatten layer. (keras-team#9696) Allow saving models directly to binary stream (keras-team#9789) Fix ctc_batch_cost() error when batch_size = 1 (keras-team#9775) Fix keras-team#9802 (keras-team#9803) Fix error in ImageDataGenerator documentation (keras-team#9798) fix typo (keras-team#9792) keras-team#9733: Extend RemoteMonitor to send data as application/json (keras-team#9734) Fixed inconsistencies regarding ReduceLROnPlateau (keras-team#9723) Fix doc issue. General stateful metrics fixes (keras-team#9446) ...
…aGenerator) (keras-team#9817) * Add documentation for 'subset' argument (flow and flow_from_directory) and for 'interpolation' argument (flow_from_directory) * Fix style for 'flow' and 'flow_from_directory' ImageDataGenerator methods doc
Methods flow (subset) and flow_from_directory (subset + interpolation) are currently missing it.