Docs update for Deconvolution2D layer #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Err... The Travis build failure seems to be unrelated to the changes, it fails Python 3.4 run on test_sequential_model_saving(): https://travis-ci.org/fchollet/keras/jobs/154395874#L1294-L1300 |
| a `weights` argument. | ||
| activation: name of activation function to use | ||
| (see [activations](../activations.md)), | ||
| or alternatively, elementwise Theano function. |
There was a problem hiding this comment.
Theano -> Theano/TensorFlow
* References formatted as Markdown links * Blank lines added
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Deconvolution2D layer was missing documentation, which is important especially because it's required to infer output shape for this layer explicitly and pass as a parameter.
One of the raised issues - #3540
Added standard docs, references and guidelines to the output shape calculation.
Also fixed typo in the exception message.