-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add xfail test for SavedModel restoring optimizer weights #15661
Conversation
@bhack could you run kokoro please? |
Sorry, I cannot assign labels in this repository |
Anything I can do here to get the ball rolling? |
@k-w-w, can you take a look for this PR? Thanks. |
Hi folks, just checking in so this doesn't go stale. It'd be great to make some progress on this long-standing footgun |
" optimizer weights" | ||
) | ||
else: | ||
self.assertAllClose(model.optimizer.weights, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I would move this in a separate test function decorating it like in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/eager/def_function_test.py#L243 with a reference to the Github ticket.
So when it is implemented the test will fail and we have a pointer to the original issue/feature request.
Then we could remove the decorator or simplify/unify the original test (the current method).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adriangb Can you handle this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I'll have bandwidth anytime soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem the comment itself is 6 months old
@adriangb Can you please resolve conflicts? Thank you! |
I'd like someone to approve this / give me some indication that this won't just sit here for another 8 months before I spend the time to resolve merge conflicts. |
@adriangb Sorry for the delay, once conflicts resolved, we will review it quickly. Thank you! |
Hi @adriangb Any update on this PR? Please. Thank you! |
Hi @adriangb I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen! Thank you! |
No description provided.