Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Removed SciPy dependency. #334

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eli-osherovich
Copy link
Contributor

Summary

Related Issues

PR Overview

  • [n] This PR requires new unit tests [y/n] (make sure tests are included)
  • [n] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • [y] This PR is backwards compatible [y/n]
  • [n] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

This is the second (last) part of the effort to remove SciPy dependency (#322)

Note: currently two tests are failing because of a bug tensorflow/addons#2357. Since the issue is not critical -- it only affects boundaries, we can adjust unit tests to follow the buggy behavior of tensorflow-addons.

@Dref360
Copy link
Contributor

Dref360 commented Jan 21, 2021

Switching to tf_addons is a pretty big change so I will reach out to Francois.

Thank you for the PR!

@eli-osherovich
Copy link
Contributor Author

eli-osherovich commented Jan 21, 2021 via email

@eli-osherovich
Copy link
Contributor Author

eli-osherovich commented Jan 24, 2021

In fact we do not need anything but TF here. Instead of tensorflow_addons one can use here tf.raw_ops.ImageProjectiveTransformV3

P. S.
updated the PR to use tensorflow only.

@Dref360
Copy link
Contributor

Dref360 commented Feb 2, 2021

Once tensorflow/tensorflow#46637 is merged I think we can merge this pr.

Thank you!

@eli-osherovich
Copy link
Contributor Author

Once tensorflow/tensorflow#46637 is merged I think we can merge this pr.

Thank you!

They will not approve it because it breaks internal tests (that are relying on the current behavior).
Should we update our unit tests to rely on the TF behavior?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants