Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drug Molecule Generation with VAE to keras 3.0 (Tensorflow backend only) #1996

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Drug Molecule Generation with VAE to keras 3.0 (Tensorflow backend only) #1996

merged 8 commits into from
Dec 17, 2024

Conversation

chunduriv
Copy link
Collaborator

This PR changes the Drug Molecule Generation with VAE to keras 3.0 (Tensorflow backend only), as requested in keras-team/keras-cv#2211

Please review the attached gist.

fchollet
fchollet reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR -- nice work!

examples/generative/molecule_generation.py Outdated Show resolved Hide resolved
examples/generative/molecule_generation.py Outdated Show resolved Hide resolved
examples/generative/molecule_generation.py Outdated Show resolved Hide resolved
examples/generative/molecule_generation.py Outdated Show resolved Hide resolved
fchollet
fchollet reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great -- please add the generated files and update scripts/examples_master.py.

mattdangerw
mattdangerw approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

examples/generative/molecule_generation.py Outdated Show resolved Hide resolved
@mattdangerw mattdangerw merged commit 132ad41 into keras-team:master Dec 17, 2024
3 checks passed
@chunduriv chunduriv deleted the veera_moleculegeneration branch February 6, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet left review comments

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees

@sachinprasadhs sachinprasadhs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chunduriv @fchollet @mattdangerw @sachinprasadhs