Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate video classification example to keras 3.0 #1674

Merged

Conversation

GuichardVictor
Copy link
Contributor

This PR migrates the video classification example to keras 3.0 as requested in keras-team/keras-cv#2211

Colab

Copy link

google-cla bot commented Dec 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

examples/vision/video_classification.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Please generate the md and ipynb files.

@divyashreepathihalli
Copy link
Contributor

@GuichardVictor Thank you for the PR - here is the process to generate the .md and .ipynb files.
you would need to go to keras-io/scipts and run python autogen.py add_example ../examples/vision/script_name.py

@GuichardVictor
Copy link
Contributor Author

Thanks you @divyashreepathihalli for explaining the process to generate the .md and .ipynb files. Will do it asap.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet fchollet merged commit a91b152 into keras-team:master Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants