Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat: Disable NATS connection on remote execution-plane configuration #524

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

TannerGabriel
Copy link
Member

This PR

  • Checks if PubSubConnectionType is HTTP or NATS and creates the correct eventsource

@TannerGabriel TannerGabriel requested review from warber and bacherfl and removed request for warber July 18, 2022 11:54
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM from my side

@TannerGabriel TannerGabriel merged commit 866624f into master Jul 18, 2022
@TannerGabriel TannerGabriel deleted the feat/go-sdk-remote-execution-plane branch July 18, 2022 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants