Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat: Use NetworkingV1 instead of deprecated ExtensionsV1beta1 #492

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

nvzard
Copy link
Contributor

@nvzard nvzard commented Jul 1, 2022

Signed-off-by: Nitanshu Vashistha [email protected]

This PR

Replaces the deprecated "k8s.io/api/extensions/v1beta1" API with "k8s.io/api/networking/v1"

Related Issues

Fixes #4432

Notes

Follow-up Tasks

How to test

@mowies mowies changed the title fix: Use NetworkingV1 instead of deprecated ExtensionsV1beta1 feat: Use NetworkingV1 instead of deprecated ExtensionsV1beta1 Jul 5, 2022
@thisthat
Copy link
Member

thisthat commented Jul 5, 2022

Hey @nvzard could you please adapt also the tests?
There is one failing: https://github.com/keptn/go-utils/runs/7192551173?check_suite_focus=true#step:4:283

@nvzard nvzard force-pushed the fix/4432/deprecation-warning branch from 81790d3 to fb5e743 Compare July 5, 2022 08:43
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@warber warber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@warber warber merged commit 0fc8c36 into keptn:master Jul 5, 2022
@nvzard nvzard deleted the fix/4432/deprecation-warning branch July 5, 2022 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI prints deprecation warning about extensions/v1beta1 when doing keptn auth
3 participants