Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix: Set the path properly for calls to api-service #470

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Jun 3, 2022

This PR fixes the logic for adapting the path for calls to the API service.
Previously, calls to the API service were resulting in the following baseURL being used:

<api-url>/api/api/v1

bacherfl added 2 commits June 3, 2022 08:10
Signed-off-by: Florian Bacher <[email protected]>

fmt.Printf("API URL: %s", a.Scheme+"://"+baseURL+v1MetadataPath)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch - will remove that

Signed-off-by: Florian Bacher <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@warber warber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, +1 for unit test :)

@bacherfl bacherfl merged commit a3c50ce into master Jun 3, 2022
@bacherfl bacherfl deleted the fix/api-service-path branch June 3, 2022 06:23
bacherfl added a commit that referenced this pull request Jun 3, 2022
* fix: Set the path properly for calls to api-service

Signed-off-by: Florian Bacher <[email protected]>

* added test

Signed-off-by: Florian Bacher <[email protected]>

* removed debug output

Signed-off-by: Florian Bacher <[email protected]>
(cherry picked from commit a3c50ce)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants