This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
feat: Added option for configuring number of retries for http event sender, as well as additional logging #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ender, as well as additional logging Signed-off-by: Florian Bacher <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -41,16 +41,26 @@ const keptnSpecVersionCEExtension = "shkeptnspecversion" | |||
| const triggeredIDCEExtension = "triggeredid" | |||
| const keptnGitCommitIDCEExtension = "gitcommitid" | |||
|
|
|||
| type HTTPSenderOption func(httpSender *HTTPEventSender) | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported type HTTPSenderOption should have comment or be unexported
| @@ -41,16 +41,26 @@ const keptnSpecVersionCEExtension = "shkeptnspecversion" | |||
| const triggeredIDCEExtension = "triggeredid" | |||
| const keptnGitCommitIDCEExtension = "gitcommitid" | |||
|
|
|||
| type HTTPSenderOption func(httpSender *HTTPEventSender) | |||
|
|
|||
| func WithSendRetries(retries int) HTTPSenderOption { | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function WithSendRetries should have comment or be unexported
Signed-off-by: Florian Bacher <[email protected]>
pkg/lib/v0_2_0/events.go
Outdated
| } | ||
| } | ||
|
|
||
| func WithRetryCallback(cb func()) HTTPSenderOption { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function WithRetryCallback should have comment or be unexported
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
May 16, 2022
bacherfl
added a commit
that referenced
this pull request
May 23, 2022
…ender, as well as additional logging (#465) * feat: Added option for configuring number of retries for http event sender, as well as additional logging Signed-off-by: Florian Bacher <[email protected]> * added option for injecting retry callback Signed-off-by: Florian Bacher <[email protected]> * added option for injecting retry callback Signed-off-by: Florian Bacher <[email protected]> * remove retry callback option Signed-off-by: Florian Bacher <[email protected]> * remove retry callback option unit test Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> (cherry picked from commit 2052e14)
bacherfl
added a commit
that referenced
this pull request
May 23, 2022
…ender, as well as additional logging (#465) (#467) * feat: Added option for configuring number of retries for http event sender, as well as additional logging Signed-off-by: Florian Bacher <[email protected]> * added option for injecting retry callback Signed-off-by: Florian Bacher <[email protected]> * added option for injecting retry callback Signed-off-by: Florian Bacher <[email protected]> * remove retry callback option Signed-off-by: Florian Bacher <[email protected]> * remove retry callback option unit test Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> (cherry picked from commit 2052e14)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an option to configure the number of retries that are performed when trying to send a cloud event. Also, the error message has been adapted to give more insights on why an event could not be sent successfully