Skip to content
This repository was archived by the owner on Dec 21, 2023. It is now read-only.

feat: added custom time parsing (keptn/keptn#4788) #348

Merged
merged 7 commits into from
Nov 9, 2021

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Nov 8, 2021

This PR

  • change time parsing to a custom one to avoid parsing errors
  • In the order we try :
    • ISO8601 : 000Z format
    • then RFC3339 : "2019-10-12T07:20:50.52Z"
    • finally a fallback userfriendly format : "2006-01-02T15:04:05"

Related Issues

keptn/keptn#4788

Notes

RFC 3339 is following the ISO 8601 DateTime format. The only difference is RFC allows us to replace “T” with “space”

@RealAnna RealAnna force-pushed the feat/4788/added-custom-time-parsing branch from e2eb868 to dffd852 Compare November 8, 2021 07:52
@RealAnna RealAnna force-pushed the feat/4788/added-custom-time-parsing branch from 7382369 to 0863bbb Compare November 8, 2021 10:33
@RealAnna RealAnna requested a review from thisthat November 8, 2021 10:35
@RealAnna RealAnna requested a review from warber November 8, 2021 11:04
Signed-off-by: RealAnna <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna requested a review from warber November 8, 2021 16:01
@RealAnna RealAnna merged commit 90baf28 into keptn:master Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants