fix: adding missing error checks (#371)

Signed-off-by: odubajDT <[email protected]>
keptn · Dec 15, 2021 · 5626bf9 · 5626bf9
1 parent de65cd4
commit 5626bf9
Show file tree

Hide file tree

Showing 8 changed files with 39 additions and 0 deletions.
diff --git a/pkg/api/utils/apiUtils.go b/pkg/api/utils/apiUtils.go
@@ -135,6 +135,9 @@ func (a *APIHandler) DeleteService(project, service string) (*models.DeleteServi
 // GetMetadata retrieve keptn MetaData information
 func (a *APIHandler) GetMetadata() (*models.Metadata, *models.Error) {
 	req, err := http.NewRequest("GET", a.Scheme+"://"+a.getBaseURL()+v1MetadataPath, nil)
+	if err != nil {
+		return nil, buildErrorResponse(err.Error())
+	}
 	req.Header.Set("Content-Type", "application/json")
 	addAuthHeader(req, a)
 

diff --git a/pkg/api/utils/eventUtils.go b/pkg/api/utils/eventUtils.go
@@ -160,6 +160,9 @@ func (e *EventHandler) getEvents(uri string, numberOfPages int) ([]*models.Keptn
 			url.RawQuery = q.Encode()
 		}
 		req, err := http.NewRequest("GET", url.String(), nil)
+		if err != nil {
+			return nil, buildErrorResponse(err.Error())
+		}
 		req.Header.Set("Content-Type", "application/json")
 		addAuthHeader(req, e)
 

diff --git a/pkg/api/utils/projectUtils.go b/pkg/api/utils/projectUtils.go
@@ -115,6 +115,9 @@ func (p *ProjectHandler) GetAllProjects() ([]*models.Project, error) {
 			url.RawQuery = q.Encode()
 		}
 		req, err := http.NewRequest("GET", url.String(), nil)
+		if err != nil {
+			return nil, err
+		}
 		req.Header.Set("Content-Type", "application/json")
 		addAuthHeader(req, p)
 

diff --git a/pkg/api/utils/resourceUtils.go b/pkg/api/utils/resourceUtils.go
@@ -210,6 +210,9 @@ func (r *ResourceHandler) writeResources(uri string, method string, resources []
 		return "", err
 	}
 	req, err := http.NewRequest(method, uri, bytes.NewBuffer(resourceStr))
+	if err != nil {
+		return "", err
+	}
 	req.Header.Set("Content-Type", "application/json")
 	addAuthHeader(req, r)
 
@@ -249,6 +252,9 @@ func (r *ResourceHandler) writeResource(uri string, method string, resource *mod
 		return "", err
 	}
 	req, err := http.NewRequest(method, uri, bytes.NewBuffer(resourceStr))
+	if err != nil {
+		return "", err
+	}
 	req.Header.Set("Content-Type", "application/json")
 	addAuthHeader(req, r)
 
@@ -279,6 +285,9 @@ func (r *ResourceHandler) writeResource(uri string, method string, resource *mod
 func (r *ResourceHandler) getResource(uri string) (*models.Resource, error) {
 	http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
 	req, err := http.NewRequest("GET", uri, nil)
+	if err != nil {
+		return nil, err
+	}
 	req.Header.Set("Content-Type", "application/json")
 	addAuthHeader(req, r)
 
@@ -320,6 +329,9 @@ func (r *ResourceHandler) getResource(uri string) (*models.Resource, error) {
 func (r *ResourceHandler) deleteResource(uri string) error {
 	http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
 	req, err := http.NewRequest("DELETE", uri, nil)
+	if err != nil {
+		return err
+	}
 	req.Header.Set("Content-Type", "application/json")
 	addAuthHeader(req, r)
 
@@ -365,6 +377,9 @@ func (r *ResourceHandler) getAllResources(u *url.URL) ([]*models.Resource, error
 			u.RawQuery = q.Encode()
 		}
 		req, err := http.NewRequest("GET", u.String(), nil)
+		if err != nil {
+			return nil, err
+		}
 		req.Header.Set("Content-Type", "application/json")
 		addAuthHeader(req, r)
 

diff --git a/pkg/api/utils/serviceUtils.go b/pkg/api/utils/serviceUtils.go
@@ -103,6 +103,9 @@ func (s *ServiceHandler) GetService(project, stage, service string) (*models.Ser
 		return nil, err
 	}
 	req, err := http.NewRequest("GET", url.String(), nil)
+	if err != nil {
+		return nil, err
+	}
 	req.Header.Set("Content-Type", "application/json")
 	addAuthHeader(req, s)
 
@@ -153,6 +156,9 @@ func (s *ServiceHandler) GetAllServices(project string, stage string) ([]*models
 			url.RawQuery = q.Encode()
 		}
 		req, err := http.NewRequest("GET", url.String(), nil)
+		if err != nil {
+			return nil, err
+		}
 		req.Header.Set("Content-Type", "application/json")
 		addAuthHeader(req, s)
 

diff --git a/pkg/api/utils/shipyardControllerUtils.go b/pkg/api/utils/shipyardControllerUtils.go
@@ -111,6 +111,9 @@ func (s *ShipyardControllerHandler) GetOpenTriggeredEvents(filter EventFilter) (
 			return nil, err
 		}
 		req, err := http.NewRequest("GET", url.String(), nil)
+		if err != nil {
+			return nil, err
+		}
 		req.Header.Set("Content-Type", "application/json")
 		addAuthHeader(req, s)
 

diff --git a/pkg/api/utils/stageUtils.go b/pkg/api/utils/stageUtils.go
@@ -106,6 +106,9 @@ func (s *StageHandler) GetAllStages(project string) ([]*models.Stage, error) {
 			url.RawQuery = q.Encode()
 		}
 		req, err := http.NewRequest("GET", url.String(), nil)
+		if err != nil {
+			return nil, err
+		}
 		req.Header.Set("Content-Type", "application/json")
 		addAuthHeader(req, s)
 

diff --git a/pkg/lib/datastore.go b/pkg/lib/datastore.go
@@ -77,6 +77,9 @@ func getLatestEvent(keptnContext string, eventType string, uri string, datastore
 
 	http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
 	req, err := http.NewRequest("GET", uri, nil)
+	if err != nil {
+		return nil, buildErrorResponse(err.Error())
+	}
 	req.Header.Set("Content-Type", "application/json")
 
 	resp, err := datastore.getHTTPClient().Do(req)