fix: Fix base branch identifier for pull requests in release workflow #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When releasing from branches containing a `/` the gh CLI call to open a
pull request specified an invalid base branch by passing `--base
"${GITHUB_REF##*/}"` which would chomp everything before a `/` in the
current GITHUB_REF (which contains refs/heads/<branchname> or
refs/tags/<tagname>). This would mangle the branch name if it contains a
`/` character so we use GITHUB_REF_NAME instead which should not contain
any prefix.
Signed-off-by: Paolo Chila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When releasing from branches containing a
/the gh CLI call to open apull request specified an invalid base branch by passing
--base "${GITHUB_REF##*/}"which chomps everything before a/in thecurrent GITHUB_REF (which contains
refs/heads/<branchname>orrefs/tags/<tagname>). This mangles the branch name if it contains a/character so we use GITHUB_REF_NAME instead which does not containany
refsprefix.Signed-off-by: Paolo Chila [email protected]